Change - NewUI - Disable extraneous UI elements when on start screen

RESOLVED FIXED in Firefox 25

Status

defect
P2
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jbecerra, Assigned: jwilde)

Tracking

Trunk
Firefox 25
x86
macOS
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [preview])

Attachments

(1 attachment, 2 obsolete attachments)

Tested on 2013-07-10 using latest nightly.

While verifying 879631 I looked into testing "find in page" functionality and I noticed that you can bring up the "Find in Page" option from the navigation app bar while you are in the start page, but it doesn't do anything.

I'm not sure if it makes sense to offer this option in the start page, but if it is meant to find strings in the top sites, bookmarks or history, it should work. It should bring up the find bar, but it doesn't.

Steps:
1. Open Firefox Metro
2. Open a new tab
3. Swipe up from the bottom to bring up the navigation app bar and click on the rightmost icon.
4. Select the option "Find in Page."

Expected: You should see the find bar come up. Or this option should not be there if it doesn't make sense to "find in page" while you are in the start page.

Actual: Nothing happens.

At the moment, I'm not sure which story this blocks.
Whiteboard: feature=defect c=Context_app_bar u=metro_firefox_user p=0
This is WFM for both cases now.
Specifically, we need to drop:

- toolbar buttons like star, pin, hamburger
- keyboard shortcuts for those various items
Assignee: nobody → jwilde
Blocks: 831910
Priority: -- → P2
Summary: defect - "Find in Page" doesn't do anything in the start page → Change - NewUI - Disable extraneous UI elements when on start screen
No longer blocks: metrov1defect&change, 831935
Whiteboard: feature=defect c=Context_app_bar u=metro_firefox_user p=0
Status: NEW → ASSIGNED
Component: General → App Bar
Posted patch patch v0 (obsolete) — Splinter Review
Posted patch hide-extraneous-v0.1 (obsolete) — Splinter Review
Also tidies up the findbar code to use our appbar sprites system.

Need a set of sprites for the navbar autocomplete close button from shorlander. We can land those in a later bug.
Attachment #784000 - Attachment is obsolete: true
Attachment #784003 - Flags: review?(mbrubeck)
Flags: needinfo?(shorlander)
Attachment #784003 - Flags: review?(mbrubeck)
Attachment #784003 - Attachment is obsolete: true
Attachment #784154 - Flags: review?(mbrubeck)
> Need a set of sprites for the navbar autocomplete close button from
> shorlander. We can land those in a later bug.

I filed bug 899980 for this off the start ui theme polish bugs.
Blocks: 899980
Attachment #784154 - Flags: review?(mbrubeck) → review+
(In reply to Jim Mathies [:jimm] from comment #6)
> > Need a set of sprites for the navbar autocomplete close button from
> > shorlander. We can land those in a later bug.
> 
> I filed bug 899980 for this off the start ui theme polish bugs.

Ah, okay. I'll close the needinfo then.
Flags: needinfo?(shorlander)
Whiteboard: [preview]
https://hg.mozilla.org/mozilla-central/rev/f4bb9ef3bf63
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
You need to log in before you can comment on or make changes to this bug.