Closed Bug 892286 Opened 7 years ago Closed 7 years ago

Cmd+L / Ctrl+L should be go to line

Categories

(DevTools :: Debugger, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 25

People

(Reporter: fitzgen, Assigned: fitzgen)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Should be able to hit Cmd+L / Ctrl+L and go to the line number you enter. Right now we have this behavior as Ctrl+J/Cmd+J.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Comment on attachment 783890 [details] [diff] [review]
v1

Review of attachment 783890 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/devtools/debugger.dtd
@@ +88,5 @@
>  
>  <!-- LOCALIZATION NOTE (debuggerUI.searchLine): This is the text that appears
>    -  in the source editor's context menu for the line search operation. -->
> +<!ENTITY debuggerUI.searchLine          "Go to line…">
> +<!ENTITY debuggerUI.searchLine.key      "L">

unfortunately you need to rename the entities. Usually by adding a number to the end of the name.

::: browser/locales/en-US/chrome/browser/devtools/debugger.properties
@@ +108,5 @@
>  searchPanelToken=Find in this file (%S)
>  
>  # LOCALIZATION NOTE (searchPanelLine): This is the text that appears in the
>  # filter panel popup for the line search operation.
> +searchPanelLine=Go to line (%S)

same thing here. Change the name.
Attachment #783890 - Flags: review?(rcampbell) → review-
Attached patch v2Splinter Review
no try push b/c trees are closed
Attachment #783890 - Attachment is obsolete: true
Attachment #783944 - Flags: review?(rcampbell)
previous try was green. Was looking to see if this key is tested anywhere and I didn't see one.

We might want to change the shortcut in the Scratchpad as well.
Attachment #783944 - Flags: review?(rcampbell) → review+
Whiteboard: [land-in-fx-team]
> We might want to change the shortcut in the Scratchpad as well.

Filed bug 900271
https://hg.mozilla.org/mozilla-central/rev/85269a38f05e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.