892339 - Fail the build when there are text relocations

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

While looking at the gold linker manual page for something else, I spotted the -z text option that barfs when the linker would need to add text relocations. GNU ld supports this too. Considering we've had problems in the past with things adding text relocations, ensuring the build fails in such case would be better than not noticing (on Linux) or failing at runtime (on Android)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Fail the build when there are text relocations

While I was there, I added -z noexecstack to js/src/configure.in to be in line with configure.in.

https://tbpl.mozilla.org/?tree=Try&rev=04228cb2cb6b

Comment 2

[Mike Hommey [:glandium]]

Note this will require a clobber.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 773766 [details] [diff] [review]
Fail the build when there are text relocations

Review of attachment 773766 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/configure.in
@@ +1165,5 @@
> +    LDFLAGS="$LDFLAGS -Wl,-z,text"
> +    AC_TRY_LINK(,,AC_MSG_RESULT([yes])
> +                  [NSPR_LDFLAGS="$NSPR_LDFLAGS -Wl,-z,text"],
> +                  AC_MSG_RESULT([no])
> +                  LDFLAGS=$_SAVE_LDFLAGS)

Creeping up on "wants to be in an m4 file" size.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/178f3283557b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/178f3283557b