Closed
Bug 892342
Opened 11 years ago
Closed 1 year ago
SystemResourceMonitor should more precisely correlate data to events and phases
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
INACTIVE
People
(Reporter: gps, Assigned: gbrown)
Details
Attachments
(1 file, 1 obsolete file)
16.31 KB,
patch
|
Details | Diff | Splinter Review |
SystemResourceMonitor has the ability to record when "events" and "phases" occur. This is used to correlate collected data with events of interest. However, the correlation to data is not precise. Data is recorded by the background process at fixed time intervals. So, data attributed to a particular phase may have come from +-<polling interval> from that phase. It was initially implemented this way because it was simple. I'd like to change the implementation of SystemResourceMonitor to record data as close as possible to when events and phases occur. This means passing a signal to the collection process telling it to collect immediately. If that signal is received, a collection is performed immediately. Once complete, regular polling resumes.
Reporter | ||
Comment 1•11 years ago
|
||
This is my first stab at it. There were a lot of assumptions baked into the old way of doing things. I'll need to give this a thorough overview before asking for review. Since the child process is now maintaining the canonical times, we have no more potential for clock skew. Therefore, I think the tests can become a lot more rigorous. Yay order!
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → gps
Reporter | ||
Comment 2•11 years ago
|
||
Most recent version. I'm pretty sure it is broken.
Reporter | ||
Updated•11 years ago
|
Attachment #773804 -
Attachment is obsolete: true
Reporter | ||
Updated•10 years ago
|
Assignee: gps → nobody
Updated•2 years ago
|
Severity: normal → S3
Assignee | ||
Updated•1 year ago
|
Assignee: nobody → gbrown
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INACTIVE
You need to log in
before you can comment on or make changes to this bug.
Description
•