Closed Bug 892342 Opened 11 years ago Closed 1 year ago

SystemResourceMonitor should more precisely correlate data to events and phases

Categories

(Testing :: Mozbase, defect)

defect

Tracking

(Not tracked)

RESOLVED INACTIVE

People

(Reporter: gps, Assigned: gbrown)

Details

Attachments

(1 file, 1 obsolete file)

SystemResourceMonitor has the ability to record when "events" and "phases" occur. This is used to correlate collected data with events of interest. However, the correlation to data is not precise. Data is recorded by the background process at fixed time intervals. So, data attributed to a particular phase may have come from +-<polling interval> from that phase. It was initially implemented this way because it was simple.

I'd like to change the implementation of SystemResourceMonitor to record data as close as possible to when events and phases occur. This means passing a signal to the collection process telling it to collect immediately. If that signal is received, a collection is performed immediately. Once complete, regular polling resumes.
This is my first stab at it. There were a lot of assumptions baked into
the old way of doing things. I'll need to give this a thorough overview
before asking for review. Since the child process is now maintaining the
canonical times, we have no more potential for clock skew. Therefore, I
think the tests can become a lot more rigorous. Yay order!
Assignee: nobody → gps
Most recent version. I'm pretty sure it is broken.
Attachment #773804 - Attachment is obsolete: true
Assignee: gps → nobody
Severity: normal → S3
Assignee: nobody → gbrown
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: