Closed Bug 892368 Opened 11 years ago Closed 5 years ago

Make the host/hostPort checks in getSourceGroup more robust

Categories

(DevTools :: Debugger, defect, P2)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: past, Unassigned)

References

(Blocks 1 open bug)

Details

In bug 876806 comment 16 Gavin said:

nsIURI in general does not make any garantees about the host/hostPort getters succeeding, so it's not just JAR URIs that can cause this to throw. E.g. data: URIs (nsSimpleURI) will have similar behavior.

A more robust check would be to check instanceof nsIStandardURL, rather than checking "scheme".
Blocks: dbg-server
Product: Firefox → DevTools

Closing since the codebase changed and the suggestion does not apply any more.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.