892378 - Let SitePermissions.jsm handle indexedDB's special use of UNKNOWN_ACTION and ALLOW_ACTION

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

I believe this matches what bent described in bug 889835. I also fixed a typo in SitePermissions.remove.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 773835 [details] [diff] [review]
patch

Review of attachment 773835 [details] [diff] [review]:
-----------------------------------------------------------------

On a side topic, could we add a migration step that fixes the pre-existing permissions to not have to use this confusing redefinition?

Comment 2

[Dão Gottwald [:dao]]

(In reply to Jared Wein [:jaws] from comment #1)
> On a side topic, could we add a migration step that fixes the pre-existing
> permissions to not have to use this confusing redefinition?

The problem is that indexedDB wants the absence of a saved state to mean "allow" (which by itself is ok, other permissions have the same behavior) but at the same time provide an opt-in "ask me every time" state. We'd have to either stop supporting that option (users could still pick "block" for sites they don't trust) or introduce a new state for it like nsIPermissionManager::ASK_ACTION.

Comment 3

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/600aee747c40

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/600aee747c40