Open Bug 892380 Opened 9 years ago Updated 4 years ago

Don't use CPPFLAGS to check cross compile check

Categories

(Firefox Build System :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

I am working clang support for Android.  Since clang's C preprocessor (clang -E) needs '-target $(llvm_target)' option for cross compile, it has to add CPPFLAGS for clang.

But cross compiler checks uses CPPFLAGS by ac_compile, it doesn't detect compiler flags well.
Attached patch fixSplinter Review
Attachment #773868 - Flags: review?(mh+mozilla)
Comment on attachment 773868 [details] [diff] [review]
fix

Review of attachment 773868 [details] [diff] [review]:
-----------------------------------------------------------------

This looks reasonable, but this doesn't quite match the bug summary.
Attachment #773868 - Flags: review?(mh+mozilla) → review+
Note that another way to look at these kind of issues is to set the compiler itself to contain such flags. So that CC="clang -target $llvm_target" and CXX="clang++ -target $llvm_target". That might make things much simpler for bug 891718
Flags: a11y-review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.