892380 - Don't use CPPFLAGS to check cross compile check

Status: NEW

(Firefox Build System :: General, defect)

Description

[Makoto Kato [:m_kato]]

I am working clang support for Android.  Since clang's C preprocessor (clang -E) needs '-target $(llvm_target)' option for cross compile, it has to add CPPFLAGS for clang.

But cross compiler checks uses CPPFLAGS by ac_compile, it doesn't detect compiler flags well.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 773868 [details] [diff] [review]
fix

Review of attachment 773868 [details] [diff] [review]:
-----------------------------------------------------------------

This looks reasonable, but this doesn't quite match the bug summary.

Comment 3

[Mike Hommey [:glandium]]

Note that another way to look at these kind of issues is to set the compiler itself to contain such flags. So that CC="clang -target $llvm_target" and CXX="clang++ -target $llvm_target". That might make things much simpler for bug 891718