892405 - In GC logging, print Max Pause Time first, not Total Time

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Andrew McCreight [:mccr8]]

It is confusing.  I thought I had a bug on this, but I don't see it.

Also, there's a typo in "Sweep Intital Shapes".

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: fix it up

I just did a minimal fix here.  This means for non-incremental GC, we'll print the reason before the total pause time, but that doesn't seem too weird. I guess I can do the test twice so the reason is later if you want.

Comment 2

[Andrew McCreight [:mccr8]]

https://tbpl.mozilla.org/?tree=Try&rev=3e18579173d7

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 775259 [details] [diff] [review]
fix it up

Review of attachment 775259 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine to me. r=me

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I assume this is not an API change, where other tools might be affected of?

Comment 5

[Terrence Cole [:terrence]]

(In reply to Henrik Skupin (:whimboo) from comment #4)
> I assume this is not an API change, where other tools might be affected of?

Correct! I do not expect this to be a problem for you, but I figured I would give a heads up just in case. Specifically, this would only affect a tool that depended on the order of the properties in the JSON objects.

Comment 6

[Andrew McCreight [:mccr8]]

Or on something containing the precise string "Sweep Intital Shapes" ;)

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thank you Terrence! It's appreciated. We will watch out for it.

Comment 8

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a4c0795e4c36

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a4c0795e4c36