Closed Bug 892408 Opened 11 years ago Closed 11 years ago

Intermittent tests/test-places-bookmarks.testResolution | snapshots have different update times - true == false | resolve handles results - "a new title" == "updated title"

Categories

(Add-on SDK Graveyard :: General, defect, P1)

Product:
Add-on SDK Graveyard
Component:
General
Platform:
x86
Windows XP
Type:
defect

Tracking

(firefox24 unaffected, firefox25 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla25
Tracking Flags:
Tracking Status
firefox24 --- unaffected
firefox25 --- fixed

People

(Reporter: emorley, Assigned: jsantell)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

GH PR 1121
176 bytes, text/html
irakli
: review+
Details 
Introduced by bug 889157.

Windows XP 32-bit mozilla-inbound pgo test jetpack on 2013-07-11 00:36:57 PDT for push 3d800f929d54

slave: t-xp32-ix-118

https://tbpl.mozilla.org/php/getParsedLog.php?id=25160369&tree=Mozilla-Inbound

{
TEST-START | tests/test-places-bookmarks.testResolution
TEST-PASS | tests/test-places-bookmarks.testResolution | bookmark has updated time
TEST-UNEXPECTED-FAIL | tests/test-places-bookmarks.testResolution | snapshots have different update times - true == false
TEST-INFO | Traceback (most recent call last):
  File "resource://gre/modules/commonjs/sdk/timers.js", line 31, in notify
    callback.apply(null, args);
  File "resource://gre/modules/commonjs/sdk/lang/functional.js", line 66, in invoke
    function invoke(callee, params, self) callee.apply(self, params);
  File "resource://gre/modules/commonjs/sdk/addon/events.js", line 27, in null
    else request.resolve(clone(data));
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 155, in then
    result.then(resolve, reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/places/bookmarks.js", line 143, in save/preCommitItem/<
    emit(emitter, 'data', savedItem, item);
  File "resource://gre/modules/commonjs/sdk/event/core.js", line 85, in emit
    for each (let item in emit.lazy.apply(emit.lazy, arguments)) {
  File "resource://gre/modules/commonjs/sdk/event/core.js", line 112, in lazy
    if (~state.indexOf(listener)) yield listener.apply(target, args);
  File "resource://extensions.modules.03556d19-5f89-4a02-938f-9f8d5e20ad28-at-jetpack.commonjs.path.tests/test-places-bookmarks.js", line 525, in exports.testResolution/</<
    assert.ok(firstSave.updated < secondSave.updated, 'snapshots have different update times');
  File "resource://gre/modules/commonjs/sdk/test/assert.js", line 103, in ok
    operator: "=="
  File "resource://gre/modules/commonjs/sdk/test/assert.js", line 89, in fail
    this._log.fail(message);
  File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 84, in fail
    this.console.testMessage(false, false, this.test.name, message);
  File "resource://gre/modules/commonjs/sdk/test/harness.js", line 523, in testMessage
    this.trace();
TEST-UNEXPECTED-FAIL | tests/test-places-bookmarks.testResolution | resolve handles results - "a new title" == "updated title"
TEST-INFO | Traceback (most recent call last):
  File "resource://gre/modules/commonjs/sdk/timers.js", line 31, in notify
    callback.apply(null, args);
  File "resource://gre/modules/commonjs/sdk/lang/functional.js", line 66, in invoke
    function invoke(callee, params, self) callee.apply(self, params);
  File "resource://gre/modules/commonjs/sdk/addon/events.js", line 27, in null
    else request.resolve(clone(data));
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 155, in then
    result.then(resolve, reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 155, in then
    result.then(resolve, reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 187, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 45, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 120, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/places/bookmarks.js", line 163, in commitComplete
    emit(emitter, 'end', results);
  File "resource://gre/modules/commonjs/sdk/event/core.js", line 85, in emit
    for each (let item in emit.lazy.apply(emit.lazy, arguments)) {
  File "resource://gre/modules/commonjs/sdk/event/core.js", line 112, in lazy
    if (~state.indexOf(listener)) yield listener.apply(target, args);
  File "resource://extensions.modules.03556d19-5f89-4a02-938f-9f8d5e20ad28-at-jetpack.commonjs.path.tests/test-places-bookmarks.js", line 540, in exports.testResolution/</</<
    assert.equal(result.title, 'a new title', 'resolve handles results');
  File "resource://gre/modules/commonjs/sdk/test/assert.js", line 125, in equal
    operator: "=="
  File "resource://gre/modules/commonjs/sdk/test/assert.js", line 89, in fail
    this._log.fail(message);
  File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 84, in fail
    this.console.testMessage(false, false, this.test.name, message);
  File "resource://gre/modules/commonjs/sdk/test/harness.js", line 523, in testMessage
    this.trace();
TEST-END | tests/test-places-bookmarks.testResolution
}
Assignee: nobody → jsantell
Attached file GH PR 1121 — 
Hoping this does the trick
Attachment #777706 - Flags: review?(evold)
Attachment #777706 - Attachment mime type: text/plain → text/html
Priority: -- → P1
Comment on attachment 777706 [details]
GH PR 1121

It's probably better if Irakli reviews, since he reviewed it initally and I don't have docs, nor do I see this `update` property mentioned in the JEP https://github.com/mozilla/addon-sdk/wiki/JEP-Places-API
Attachment #777706 - Flags: review?(evold) → review?(rFobic)
(In reply to Erik Vold [:erikvold] [:ztatic] from comment #52)
> Comment on attachment 777706 [details]
> GH PR 1121
> 
> It's probably better if Irakli reviews, since he reviewed it initally and I
> don't have docs, nor do I see this `update` property mentioned in the JEP
> https://github.com/mozilla/addon-sdk/wiki/JEP-Places-API

s/`update`/`updated`
Comment on attachment 777706 [details]
GH PR 1121

r+ With comments in pull request addressed.
Attachment #777706 - Flags: review?(rFobic) → review+
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/d9ceb0476d1bcefb5cd9f42fe267814acf188da6
Merge pull request #1121 from jsantell/892408-fix-intermittent-bookmarks-resolution

fix bug 892408 fix intermittent bookmarks resolution errors, r=@gozala
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
status-firefox24: --- → unaffected
status-firefox25: --- → fixed
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: