If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Failure "TypeError: forwardButton.removeEventListener is not a function" in testToolbar/testBackForwardButtons.js

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

({regression})

unspecified
regression

Firefox Tracking Flags

(firefox22 fixed, firefox23 fixed, firefox24 fixed, firefox25 fixed, firefox-esr17 fixed)

Details

(Whiteboard: [mozmill-test-failure])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

4 years ago
This failure has been introduced by bug 704140. It's kinda obvious that this cannot work. Not sure why I only see this in Mozmill 2.0 but not Mozmill 1.5.

  function onTransitionEnd() {
    transitionFinished = true;
->  forwardButton.removeEventListener("transitionend", onTransitionEnd, false);
  }

Here we just miss to call getNode().
(Assignee)

Comment 1

4 years ago
Created attachment 773872 [details] [diff] [review]
Patch v1
Attachment #773872 - Flags: review?(andreea.matei)
(Assignee)

Comment 2

4 years ago
Created attachment 773877 [details] [diff] [review]
Patch v1.1

Ups, that was a broken patch.
Attachment #773872 - Attachment is obsolete: true
Attachment #773872 - Flags: review?(andreea.matei)
Attachment #773877 - Flags: review?(andreea.matei)
Comment on attachment 773877 [details] [diff] [review]
Patch v1.1

Review of attachment 773877 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #773877 - Flags: review?(andreea.matei) → review+
(Assignee)

Comment 4

4 years ago
Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/76feb8166296
status-firefox22: --- → affected
status-firefox23: --- → affected
status-firefox24: --- → affected
status-firefox25: --- → fixed
status-firefox-esr17: --- → affected
(Assignee)

Comment 5

4 years ago
Landed on aurora, and beta:
http://hg.mozilla.org/qa/mozmill-tests/rev/82145bfd4288 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/11be910a8193 (beta)

For release and esr17 we need a new patch.
status-firefox23: affected → fixed
status-firefox24: affected → fixed
(Assignee)

Comment 6

4 years ago
Created attachment 775055 [details] [diff] [review]
Patch (backport release)
Attachment #775055 - Flags: review?(andreea.matei)
Comment on attachment 775055 [details] [diff] [review]
Patch (backport release)

Review of attachment 775055 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #775055 - Flags: review?(andreea.matei) → review+
(Assignee)

Comment 8

4 years ago
Landed backport patch:
http://hg.mozilla.org/qa/mozmill-tests/rev/e06bbeae3a0e (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/aded8c768c00 (esr17)
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
status-firefox22: affected → fixed
status-firefox-esr17: affected → fixed
You need to log in before you can comment on or make changes to this bug.