892415 - Failure "TypeError: forwardButton.removeEventListener is not a function" in testToolbar/testBackForwardButtons.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

This failure has been introduced by bug 704140. It's kinda obvious that this cannot work. Not sure why I only see this in Mozmill 2.0 but not Mozmill 1.5.

  function onTransitionEnd() {
    transitionFinished = true;
->  forwardButton.removeEventListener("transitionend", onTransitionEnd, false);
  }

Here we just miss to call getNode().

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1.1

Ups, that was a broken patch.

Comment 3

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 773877 [details] [diff] [review]
Patch v1.1

Review of attachment 773877 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/76feb8166296

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed on aurora, and beta:
http://hg.mozilla.org/qa/mozmill-tests/rev/82145bfd4288 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/11be910a8193 (beta)

For release and esr17 we need a new patch.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch (backport release)

Comment 7

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 775055 [details] [diff] [review]
Patch (backport release)

Review of attachment 775055 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed backport patch:
http://hg.mozilla.org/qa/mozmill-tests/rev/e06bbeae3a0e (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/aded8c768c00 (esr17)