Permanent Orange (Windows): TEST-UNEXPECTED-FAIL | test-plugin-crashing.js | test_can_crash_plugin, test_crashed_plugin_notification_bar, test_crashed_plugin_notification_inline

RESOLVED FIXED in Thunderbird 25.0

Status

Thunderbird
Toolbars and Tabs
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

({intermittent-failure})

Trunk
Thunderbird 25.0
All
Windows 7
intermittent-failure

Thunderbird Tracking Flags

(thunderbird24 fixed)

Details

Attachments

(1 attachment)

Since we got the Windows green again, we're seeing these timeouts on windows:

TEST-START | C:\talos-slave\test\build\mozmill\content-tabs\test-plugin-crashing.js | test_can_crash_plugin
Test Failure: Timeout waiting for crash
TEST-START | C:\talos-slave\test\build\mozmill\content-tabs\test-plugin-crashing.js | teardownTest
TEST-PASS | C:\talos-slave\test\build\mozmill\content-tabs\test-plugin-crashing.js | test-plugin-crashing.js::teardownTest
TEST-UNEXPECTED-FAIL | C:\talos-slave\test\build\mozmill\content-tabs\test-plugin-crashing.js | test-plugin-crashing.js::test_can_crash_plugin
TEST-START | C:\talos-slave\test\build\mozmill\content-tabs\test-plugin-crashing.js | setupTest
Step Pass: {"function": "controller.click()"}
TEST-PASS | C:\talos-slave\test\build\mozmill\content-tabs\test-plugin-crashing.js | test-plugin-crashing.js::setupTest
TEST-START | C:\talos-slave\test\build\mozmill\content-tabs\test-plugin-crashing.js | test_crashed_plugin_notification_bar
Test Failure: Timeout waiting for crash
TEST-START | C:\talos-slave\test\build\mozmill\content-tabs\test-plugin-crashing.js | teardownTest
TEST-PASS | C:\talos-slave\test\build\mozmill\content-tabs\test-plugin-crashing.js | test-plugin-crashing.js::teardownTest
TEST-UNEXPECTED-FAIL | C:\talos-slave\test\build\mozmill\content-tabs\test-plugin-crashing.js | test-plugin-crashing.js::test_crashed_plugin_notification_bar
TEST-START | C:\talos-slave\test\build\mozmill\content-tabs\test-plugin-crashing.js | setupTest
Step Pass: {"function": "controller.click()"}
TEST-PASS | C:\talos-slave\test\build\mozmill\content-tabs\test-plugin-crashing.js | test-plugin-crashing.js::setupTest
TEST-START | C:\talos-slave\test\build\mozmill\content-tabs\test-plugin-crashing.js | test_crashed_plugin_notification_inline
Test Failure: Timeout waiting for crash
TEST-START | C:\talos-slave\test\build\mozmill\content-tabs\test-plugin-crashing.js | teardownTest
TEST-PASS | C:\talos-slave\test\build\mozmill\content-tabs\test-plugin-crashing.js | test-plugin-crashing.js::teardownTest
TEST-UNEXPECTED-FAIL | C:\talos-slave\test\build\mozmill\content-tabs\test-plugin-crashing.js | test-plugin-crashing.js::test_crashed_plugin_notification_inline

Comment 1

4 years ago
Wasn't bug 891745 supposed to fix this? Or what is the difference?

I see this bug was filed for failures before patch for bug 891745 has landed.
Bug 891745 was an random orange issue seen on Linux. This seems to be a Windows-only issue.
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)

Comment 21

4 years ago
You also suggest bug 883563 is the culprit of this, but I do not see the relation.
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Assignee: nobody → mbanner
Created attachment 779984 [details] [diff] [review]
The fix

Looking at arbpl and about the fact that blocklist updates are async and need to be forced (http://hg.mozilla.org/comm-central/rev/6fe31acd7594), gave me the clue to fixing this.

Basically, the previous test is leaving us in a bad state wrt the blocklist, which is causing this to fail. It only fails on windows and not linux, I'm guessing to do with the order in which files are checked out.

On trunk there's still a remaining failure, but as that is the same as the linux one, I'm pretty sure there's a different bug causing it, which I will track down later (I know the regression range).

Try results are here: https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=473c89ad7eec
Attachment #779984 - Flags: review?(mconley)
Comment on attachment 779984 [details] [diff] [review]
The fix

Review of attachment 779984 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with my little concerns addressed.

::: mail/test/mozmill/content-tabs/test-plugin-blocked.js
@@ +73,4 @@
>    mc.waitFor(function () { return testDone; }, "Plugin test taking too long",
>               100000, 1000);
>  
> +  var finishedReset = false;

let, not var

@@ +76,5 @@
> +  var finishedReset = false;
> +
> +  resetBlocklist(mc, function() { finishedReset = true; });
> +
> +  mc.waitFor(function () { return finishedReset; }, "Reset blocklist took too long",

This can be simplified to:

mc.waitFor(function() finishedReset, "Reset blocklist took too long");

Unless there's a reason to manually set the timeout / interval.

::: mail/test/mozmill/content-tabs/test-plugin-outdated.js
@@ +59,4 @@
>    mc.waitFor(function () { return testDone; }, "Plugin test taking too long",
>               100000, 1000);
>  
> +  var finishedReset = false;

Same notes as above.
Attachment #779984 - Flags: review?(mconley) → review+
Calling this fixed, I'll track down the other bug tomorrow:

https://hg.mozilla.org/comm-central/rev/7416f85f1f1c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 25.0
Comment on attachment 779984 [details] [diff] [review]
The fix

[Triage Comment]
As I know this passed try server, taking straight onto aurora to help fix bustage there.
Attachment #779984 - Flags: approval-comm-aurora+
https://hg.mozilla.org/releases/comm-aurora/rev/9b01cd6a5522
status-thunderbird24: --- → fixed
You need to log in before you can comment on or make changes to this bug.