892447 - [SMS] 'getMessages': Handle errors in cursor properly

Status: RESOLVED DUPLICATE of bug 893838

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Borja Salguero [:borjasalguero]]

We need to ensure the right management of errors during the 'getMessages' request to Gecko.

Comment 1

[Borja Salguero [:borjasalguero]]

Here we are going to address the following suggestion:

Gabriele Svelto [:gsvelto]:
> (In reply to Chuck Lee [:chucklee] from comment #38)
> > I noticed that, the deleting process are assuming every operation will
> > success.
> > If there's an |cursor.onerror| in the |getMessages()|, the DOMs are deleted,
> > but messages in DB are not.
> > Maybe we need a way to recovery these DOMs should this happens?
> 
> I think the best way would be to invert the order in which we're doing
> operations, i.e. gather all messages from the threads we want to delete
> (using |cursor.onerror| to exclude the threads for which we hit errors),
> delete the messages and then remove the threads we're sure we have deleted
> from the DOM in one go.