Closed
Bug 892491
Opened 11 years ago
Closed 11 years ago
[AccessFu] Add quick navigation item for landmarks
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: MarcoZ, Assigned: MarcoZ)
References
Details
Attachments
(1 file)
7.39 KB,
patch
|
eeejay
:
review+
|
Details | Diff | Splinter Review |
Now that we utter landmarks, we should also add an item to the quick navigation system to allow the user to jump from landmark to landmark.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #774068 -
Flags: review?(eitan)
Comment 2•11 years ago
|
||
Comment on attachment 774068 [details] [diff] [review] [AccessFu] Add landmark quick navigation, Review of attachment 774068 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. We really need to fix the pivot API so it were more container friendly. But overall, great. ::: accessible/src/jsat/Utils.jsm @@ +261,5 @@ > > return true; > + }, > + > + gLandmarks: [ This should just be a const member of getLandmarkName.
Attachment #774068 -
Flags: review?(eitan) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/df5a4a4a99ee
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → marco.zehe
Status: NEW → ASSIGNED
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/df5a4a4a99ee
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•