[AccessFu] Add quick navigation item for landmarks

RESOLVED FIXED in mozilla25

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: MarcoZ, Assigned: MarcoZ)

Tracking

Trunk
mozilla25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Now that we utter landmarks, we should also add an item to the quick navigation system to allow the user to jump from landmark to landmark.
(Assignee)

Comment 1

6 years ago
Created attachment 774068 [details] [diff] [review]
[AccessFu] Add landmark quick navigation,
Attachment #774068 - Flags: review?(eitan)
Comment on attachment 774068 [details] [diff] [review]
[AccessFu] Add landmark quick navigation,

Review of attachment 774068 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. We really need to fix the pivot API so it were more container friendly. But overall, great.

::: accessible/src/jsat/Utils.jsm
@@ +261,5 @@
>  
>      return true;
> +  },
> +
> +  gLandmarks: [

This should just be a const member of getLandmarkName.
Attachment #774068 - Flags: review?(eitan) → review+
(Assignee)

Updated

6 years ago
Assignee: nobody → marco.zehe
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/df5a4a4a99ee
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.