Closed
Bug 892511
Opened 11 years ago
Closed 11 years ago
rewrite test_{title,window}.xul to not rely on shared setTimeout between windows
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: froydnj, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
11.25 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
This patch came up in the context of bug 715376, but is independent and complicated enough that it's worth splitting into its own bug.
Reporter | ||
Comment 1•11 years ago
|
||
The problem here is that the test assumes that calling SimpleTest.executeSoon() (which calls setTimeout) will fire all the events queued up by the testDynamic() calls. If any of the iframes have separate event queues, events in those queues are not guaranteed to have fired by the time the owning window executes the executeSoon() timeout. So we have to make each test iframe spin its own event queue before starting the next test. This is really only relevant in the context of bug 715376 (or similar) being landed, but I think we might as well land this in the interim.
Attachment #773991 -
Flags: review?(bugs)
Updated•11 years ago
|
Attachment #773991 -
Flags: review?(bugs) → review+
Comment 2•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/da344a3836ae
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Assignee | ||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•