892570 - [B2G][l10n][Crash Report] Spanish: Header of "Crash Report" has ellipses

Status: VERIFIED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Deepa Subramanian]

Attachment: Screenshot

Description:
When the user clicks the link "What's in a crash report?" in the crash report screen, the user sees the header of the "Crash Report" with ellipses.

Repro Steps:
1) Updated to Leo Build ID: 20130711070209
2) Set the language to Spanish
3) Use Cgywin commands to produce a crash 
4) On the Crash Report page, click the link "What's in a crash report?"
5) Crash Report details are displayed

Actual:
Crash Report header with ellipses
Expected:
Crash Report header without ellipses

Environmental Variables
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/aaa74e5efaf1
Gaia: 7cdcc46179d198cab11970964b181ede32a5b683
Platform Version: 18.1

Notes:
Repro frequency: 100%
See attached: Screenshot

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Not sure localizers can shorten anything up here, but adding them just in case...
probably more something to see with UX team

Comment 2

[RickieES aka Ricardo Palomares]

Yes, I can't see any way to reduce the string, as changing the number from "Informes" to "Informe" to describe a general explanation about crash reports would sound akward.

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

Ok as per Leo blocker guidelines, nominating as Leo and asking for UX help here

Comment 4

[bhavana bajaj [:bajaj]]

This does not block a user from performing anything actionable so this is a minor polish issue and not a blocker.Moving to koi ? to resolve in future releases

Comment 5

[Eric Pang [:epang] UX]

Is there a more general term for 'Crash Reports' that can be used in the header?  Then on top of the main copy a heading can be added with the full translation of "Crash Reports"?  If a mock up is needed please needinfo me with the new text for the header and full translation of "Crash Report" in Spanish. Thanks!

Comment 6

[RickieES aka Ricardo Palomares]

(In reply to Eric Pang [:epang] from comment #5)
> Is there a more general term for 'Crash Reports' that can be used in the
> header?


I don't think so (it's a two words expression, there is not much to play with). :-)

OTOH, I've come across the same screen through Settings -> Enhance Firefox OS -> Crash Reports -> _More info_ link, and the title "Informes de errores" is correctly displayed, mainly because there is no "OK" button in the title bar. So I wonder:

- Are we using "Informes de errores" or "Informes de error"? Apparently, we're using the former (apps/system); we could shorten it to the latter just to check if it fits, although It wouldn't bet my hand on it.

- Is absolutely needed to put the OK button in the title bar? BTW, I don't understand why something that represents a "Read and done" action is put at the beginning of the UI and not at the end (this happens in many places in Firefox OS UI and I find it awkward; yes, it happens also in Android and yes, I find it awkward there, too).

- Couldn't the left margin in the title bar be reduced? I know I'm always claiming for less margins, but in such small screens, the space should be better squeezed.

Comment 7

[Eric Pang [:epang] UX]

(In reply to Ricardo Palomares from comment #6)
> (In reply to Eric Pang [:epang] from comment #5)
> > Is there a more general term for 'Crash Reports' that can be used in the
> > header?
> 
> 
> I don't think so (it's a two words expression, there is not much to play
> with). :-)
> 
> OTOH, I've come across the same screen through Settings -> Enhance Firefox
> OS -> Crash Reports -> _More info_ link, and the title "Informes de errores"
> is correctly displayed, mainly because there is no "OK" button in the title
> bar. So I wonder:
> 
> - Are we using "Informes de errores" or "Informes de error"? Apparently,
> we're using the former (apps/system); we could shorten it to the latter just
> to check if it fits, although It wouldn't bet my hand on it.

I'm not sure, localization would have made this decision

 
> - Is absolutely needed to put the OK button in the title bar? BTW, I don't
> understand why something that represents a "Read and done" action is put at
> the beginning of the UI and not at the end (this happens in many places in
> Firefox OS UI and I find it awkward; yes, it happens also in Android and
> yes, I find it awkward there, too).

If it's a "read and done" action I would say we replace the ok button with a close  button (on the left) which takes up much less space and should solve the problem.  What do you think?

> - Couldn't the left margin in the title bar be reduced? I know I'm always
> claiming for less margins, but in such small screens, the space should be
> better squeezed.

We can't shift left since the space there is allocated in case there's a need for a back or close button.

I think the best option would be to add a close button on the left and remove the ok button on the right.

Comment 8

[RickieES aka Ricardo Palomares]

(In reply to Eric Pang [:epang] from comment #7)
> (In reply to Ricardo Palomares from comment #6)
> > OTOH, I've come across the same screen through Settings -> Enhance Firefox
> > OS -> Crash Reports -> _More info_ link, and the title "Informes de errores"
> > is correctly displayed, mainly because there is no "OK" button in the title
> > bar. So I wonder:
> > 
> > - Are we using "Informes de errores" or "Informes de error"? Apparently,
> > we're using the former (apps/system); we could shorten it to the latter just
> > to check if it fits, although It wouldn't bet my hand on it.
> 
> I'm not sure, localization would have made this decision


I'm a localizer myself, so I was more of asking to Inma and Guillermo. :-)


> > - Is absolutely needed to put the OK button in the title bar? BTW, I don't
> > understand why something that represents a "Read and done" action is put at
> > the beginning of the UI and not at the end (this happens in many places in
> > Firefox OS UI and I find it awkward; yes, it happens also in Android and
> > yes, I find it awkward there, too).
> 
> If it's a "read and done" action I would say we replace the ok button with a
> close  button (on the left) which takes up much less space and should solve
> the problem.  What do you think?


Actually, that's exactly how it looks in Settings -> Enhance Firefox OS -> Crash Reports -> _More info_ link. So, yes, it would work. :-)


> I think the best option would be to add a close button on the left and
> remove the ok button on the right.

I agree.

Comment 9

[Inma Barrios]

(In reply to Ricardo Palomares from comment #8)
> (In reply to Eric Pang [:epang] from comment #7)
> > (In reply to Ricardo Palomares from comment #6)
> > > 
> > > - Are we using "Informes de errores" or "Informes de error"? Apparently,
> > > we're using the former (apps/system); we could shorten it to the latter just
> > > to check if it fits, although It wouldn't bet my hand on it.
> > 
> > I'm not sure, localization would have made this decision
> 
> 
> I'm a localizer myself, so I was more of asking to Inma and Guillermo. :-)

Hey guys,

Just edited the strings in appssettings and appssystem to keep those phrases consistent: "informes de error". 

Thanks for the catch!
> 
> 
> > > - Is absolutely needed to put the OK button in the title bar? BTW, I don't
> > > understand why something that represents a "Read and done" action is put at
> > > the beginning of the UI and not at the end (this happens in many places in
> > > Firefox OS UI and I find it awkward; yes, it happens also in Android and
> > > yes, I find it awkward there, too).
> >

Comment 10

[Preeti Raghunath(:Preeti)]

Delphine,

Please help move this ahead for checkin.

Comment 11

[Delphine Lebédel [:delphine - Use needinfo]]

Mila, could you please check if this issue has been resolved?
thanks

Comment 12

[Mila Davydova]

This issue still reproduces on v1.1 Leo COM RIL Build. When the user clicks the link "What's in a crash report?", the user sees the header of the "Crash Report" with ellipses. 

Build ID: 20130918041204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6b8a7556ab2e
Gaia: 7310d9fd969db201bdc9ff275a3ac8b537f7070a
Platform Version: 18.1
RIL Version: 01.01.00.019.227

Comment 13

[Preeti Raghunath(:Preeti)]

Mila,

Can you please check b2g-26?

Comment 14

[Mila Davydova]

This issue does not reproduce on b2g-26
Buri Build ID: 20130916040205
Gecko: http://hg.mozilla.org/mozilla-central/rev/c4bcef90cef9
Gaia: a0079597d510ce8ea0b9cbb02c506030510b9eeb
Platform Version: 26.0a1

also, does not repro on 1.2 aurora build:
Buri Build ID: 20130925004005
Gecko: http://hg.mozilla.org/releases/mozilla-aurora/rev/fb764e648a8f
Gaia: b0e4a1333bb7bf0a749a384ba99e4f03f111e39a
Platform Version: 26.0a2

Comment 15

[Preeti Raghunath(:Preeti)]

Per QA's comment 14,

This will be a minus

Comment 16

[Francesco Lodolo [:flod]]

Is this still an issue?

Comment 17

[Francesco Lodolo [:flod]]

Closing based on comment 14

Comment 18

[Delphine Lebédel [:delphine - Use needinfo]]

Verified, marking as so