Closed
Bug 892594
Opened 12 years ago
Closed 12 years ago
Fix LIR-Common.h to work with clang++ 4.1
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: abr, Assigned: abr)
References
Details
Attachments
(1 file, 2 obsolete files)
|
1.34 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
Recent changes have resulted in build failures for clang++ 4.1,
which is (in theory) still a supported compiler.
|
Assignee | |
Comment 1•12 years ago
|
||
Make virtual methods in LControlInstructionHelper explicitly virtual.
Attachment #774123 -
Flags: review?(evilpies)
|
||
Comment 2•12 years ago
|
||
This has:
[13:53:11] <nbp> r=nbp
from IRC. I'm waiting for the tree to open to check it in.
Assignee: adam → mrbkap
Attachment #774123 -
Attachment is obsolete: true
Attachment #774123 -
Flags: review?(evilpies)
Attachment #774138 -
Flags: review+
|
|
||
Comment 3•12 years ago
|
||
nbp realized just now that Adam's patch is actually more correct.
Assignee: mrbkap → adam
|
|
||
Updated•12 years ago
|
Attachment #774138 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•12 years ago
|
Attachment #774123 -
Attachment is obsolete: false
Attachment #774123 -
Flags: review?(nicolas.b.pierron)
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Attachment #774123 -
Attachment is obsolete: true
Attachment #774123 -
Flags: review?(nicolas.b.pierron)
|
||
Updated•12 years ago
|
Attachment #774153 -
Flags: review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
|
||
Comment 6•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•