Fix LIR-Common.h to work with clang++ 4.1

RESOLVED FIXED in mozilla25

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: abr, Assigned: abr)

Tracking

unspecified
mozilla25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Recent changes have resulted in build failures for clang++ 4.1,
which is (in theory) still a supported compiler.
(Assignee)

Comment 1

5 years ago
Created attachment 774123 [details] [diff] [review]
Make virtual methods in LControlInstructionHelper explicitly virtual.

Make virtual methods in LControlInstructionHelper explicitly virtual.
Attachment #774123 - Flags: review?(evilpies)
Created attachment 774138 [details] [diff] [review]
Alternative fix

This has:

[13:53:11] <nbp> r=nbp

from IRC. I'm waiting for the tree to open to check it in.
Assignee: adam → mrbkap
Attachment #774123 - Attachment is obsolete: true
Attachment #774123 - Flags: review?(evilpies)
Attachment #774138 - Flags: review+
nbp realized just now that Adam's patch is actually more correct.
Assignee: mrbkap → adam
Attachment #774138 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Attachment #774123 - Attachment is obsolete: false
Attachment #774123 - Flags: review?(nicolas.b.pierron)
(Assignee)

Comment 4

5 years ago
Created attachment 774153 [details] [diff] [review]
Fix LIR-Common.h to work with clang++ 4.1
(Assignee)

Updated

5 years ago
Attachment #774123 - Attachment is obsolete: true
Attachment #774123 - Flags: review?(nicolas.b.pierron)
Attachment #774153 - Flags: review+
Blocks: 891087
https://hg.mozilla.org/mozilla-central/rev/c6a4d9a48b04
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.