Closed Bug 892594 Opened 8 years ago Closed 8 years ago

Fix LIR-Common.h to work with clang++ 4.1

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: abr, Assigned: abr)

References

Details

Attachments

(1 file, 2 obsolete files)

Recent changes have resulted in build failures for clang++ 4.1,
which is (in theory) still a supported compiler.
Make virtual methods in LControlInstructionHelper explicitly virtual.
Attachment #774123 - Flags: review?(evilpies)
Attached patch Alternative fix (obsolete) — Splinter Review
This has:

[13:53:11] <nbp> r=nbp

from IRC. I'm waiting for the tree to open to check it in.
Assignee: adam → mrbkap
Attachment #774123 - Attachment is obsolete: true
Attachment #774123 - Flags: review?(evilpies)
Attachment #774138 - Flags: review+
nbp realized just now that Adam's patch is actually more correct.
Assignee: mrbkap → adam
Attachment #774138 - Attachment is obsolete: true
Attachment #774123 - Attachment is obsolete: false
Attachment #774123 - Flags: review?(nicolas.b.pierron)
Attachment #774123 - Attachment is obsolete: true
Attachment #774123 - Flags: review?(nicolas.b.pierron)
https://hg.mozilla.org/mozilla-central/rev/c6a4d9a48b04
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.