892618 - Improve ElasticSearch indexing of application version listings

Status: VERIFIED FIXED

(Marketplace Graveyard :: API, defect, P2)

Description

[Chuck Harmston [:chuck]]

Rob has some ideas for indexing application versions in the API. It is current served as such:

"current_version": "1.1",
"versions": {
  "1.0": "/api/v1/apps/versions/7012/",
  "1.1": "/api/v1/apps/versions/7930/"
}

But this requires a bit of a cheat in the mapping. To keep indexes smaller and searches faster, we should index like this:

"current_version": "1.1",
"versions": [{
  "version": "1.0",
  "resource_uri": "/api/v1/apps/versions/7012/"}, {
  "version": "1.1",
  "resource_uri": "/api/v1/apps/versions/7930/"
}]

And flatten on the way out.

Comment 1

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/7456461

Comment 2

[Victor Carciu]

Can you please add some STRs to this bug or mark it as [qa-] ?

Comment 3

[Rob Hudson [:robhudson]]

I've changed the way we store versions in elasticsearch. If you could, please verify via the API that versions come out in the form:

"versions": {
  "1.0": "/api/v1/apps/versions/7012/",
  "1.1": "/api/v1/apps/versions/7930/"
}

1. Search for an app, watching the network panel.
2. Verify that the JSON result from the search API for a packaged app with multiple versions contains a "versions" attribute like the above.

Comment 4

[Wil Clouser [:clouserw]]

We had to back this patch out because it broke our production push.  This needs to fail gracefully using an old version of the index before the new one exists.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/b6142a9

Comment 6

[Rob Hudson [:robhudson]]

(In reply to Wil Clouser [:clouserw] from comment #4)
> We had to back this patch out because it broke our production push.  This
> needs to fail gracefully using an old version of the index before the new
> one exists.

Roger that. I can pick this up again and ensure it doesn't break on top of old data.

Comment 7

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/a6e9242

Comment 8

[krupa raj[:krupa]]

verified fixed at https://marketplace-dev.allizom.org/api/v1/apps/search/?lang=en-US&pro=8a35d06e.32.1&q=jaxogram&region=pl