Localize /about /getinvolved and /mentor on webmaker.org and the rest of the pages

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: alicoding, Assigned: alicoding)

Tracking

Details

(Whiteboard: s=2013w29 p=1)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Localize /about /getinvolved and /mentor on webmaker.org
(Assignee)

Updated

5 years ago
Whiteboard: wb.localization
(Assignee)

Updated

5 years ago
Assignee: nobody → ali
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Whiteboard: wb.localization → wb.localization,s=2013w29

Updated

5 years ago
Whiteboard: wb.localization,s=2013w29 → s=2013w29 p=1
(Assignee)

Updated

5 years ago
Depends on: 891491
(Assignee)

Updated

5 years ago
Summary: Localize /about /getinvolved and /mentor on webmaker.org → Localize /about /getinvolved and /mentor on webmaker.org and the rest of the pages

Comment 2

5 years ago
Comment on attachment 781121 [details] [review]
https://github.com/mozilla/webmaker.org/pull/280

There's a number of mystery newlines but more important, we're using nunjucks' "safe" keyword for a number of values that actually contain HTML, which means they'll get rendered as literal text instead of as styled/marked up text/elements. I didn't flag all of them, just three, but there's probably more.
Attachment #781121 - Flags: review?(pomax) → review-
(Assignee)

Comment 3

5 years ago
Comment on attachment 781121 [details] [review]
https://github.com/mozilla/webmaker.org/pull/280

I have fixed the newline issue there, but with the safe filter I think without it then it won't display the markup because we have set to escape all the HTML in app.js.
Attachment #781121 - Flags: review- → review?(pomax)

Comment 4

5 years ago
Comment on attachment 781121 [details] [review]
https://github.com/mozilla/webmaker.org/pull/280

I didn't say anything.
Attachment #781121 - Flags: review?(pomax) → review+

Comment 5

5 years ago
Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/ac9b93e081c972315327af43ec6719ae1b94be42
bug892636 Localize /about /getinvolved and /mentor on webmaker.org
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.