Closed Bug 892646 Opened 7 years ago Closed 7 years ago

Remove unused library link list files

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla25

People

(Reporter: gps, Assigned: gps)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

https://mxr.mozilla.org/mozilla-central/source/config/makefiles/target_export.mk#38 is producing simple lists from build config defined variables.

We should be able to produce these lists at RecursiveMakeBackend generation time.

These files/lists may eventually be eliminated once we have a better binary generation mechanism in place. Until then, this is an export rule and is blocking bug 892644. Unless someone has a better solution, I say we generate them at config.status time and do something better later.
As tbsaunde pointed out on IRC, final-link-libs doesn't appear to be used!

I believe he is correct:

https://mxr.mozilla.org/mozilla-central/search?string=final[_\-]link&regexp=1

I found a reference to it in a commit in 2001. I suspect whatever it was used for is long gone. Let's see what happens if I remove it...
I love removing code.
Attachment #774386 - Flags: review?(mh+mozilla)
Assignee: nobody → gps
Comment on attachment 774386 [details] [diff] [review]
Remove unsued final-link-{libs,comps,comp-names} files

Review of attachment 774386 [details] [diff] [review]:
-----------------------------------------------------------------

I like removals, but you're likely breaking config/makefiles/test by removing that .mk without touching config/makefiles/test/Makefile.in.
Attachment #774386 - Flags: review?(mh+mozilla) → review-
Removed reference to deleted test. That's what I get for assuming the
Makefile.in just did a $(wildcard).
Attachment #774428 - Flags: review?(mh+mozilla)
Attachment #774386 - Attachment is obsolete: true
Attachment #774428 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/1334356b294c
Status: NEW → ASSIGNED
Summary: Create library link list files in RecursiveMakeBackend → Remove unused library link list files
https://hg.mozilla.org/mozilla-central/rev/1334356b294c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.