892647 - DOMRequestIpcHelperMessageListener is destroyed twice when inner window is destroyed

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

The inner-window-destroyed event leads to DOMRequestIpcHelperMessageListener.destroy() being called, which calls DOMRequestIpcHelper.destroy(), which calls back into the message listener destroy(). removeObserver() throws an error.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Add check to prevent destroy actions from running twice.

Comment 2

[Justin Lebar (not reading bugmail)]

Comment on attachment 774184 [details] [diff] [review]
Add check to prevent destroy actions from running twice.

r=me; thanks for catching this!

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e47b0cd496f8

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e47b0cd496f8