DOMRequestIpcHelperMessageListener is destroyed twice when inner window is destroyed

RESOLVED FIXED in mozilla25

Status

RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: nsm, Assigned: nsm)

Tracking

unspecified
mozilla25
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The inner-window-destroyed event leads to DOMRequestIpcHelperMessageListener.destroy() being called, which calls DOMRequestIpcHelper.destroy(), which calls back into the message listener destroy(). removeObserver() throws an error.
Created attachment 774184 [details] [diff] [review]
Add check to prevent destroy actions from running twice.
Attachment #774184 - Flags: review?(justin.lebar+bug)
Comment on attachment 774184 [details] [diff] [review]
Add check to prevent destroy actions from running twice.

r=me; thanks for catching this!
Attachment #774184 - Flags: review?(justin.lebar+bug) → review+
https://hg.mozilla.org/mozilla-central/rev/e47b0cd496f8
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25

Updated

a year ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.