892694 - Cannot submit an updated packaged app with the same origin as the old version of the app

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P1)

Description

[Jason Smith [:jsmith]]

STR

1. Submit a privileged app to marketplace with a valid origin (e.g. app://test.webapi.permissions.com)
2. Publish that app
3. Go to Manage Status & Versions
4. Under upload new version, try to upload a privileged app with a new version that contains the same origin as #1

Expected

The app should be uploaded successfully.

Actual

The app fails to be uploaded successfully with an error saying - An app already exists on this domain; only one app per domain is allowed. This isn't right - if an app specifies an origin in their manifest that matches the old version of the app, then it should be allowed to be uploaded.

Comment 1

[Rob Hudson [:robhudson]]

P1 b/c it's blocking QA.

We need to exclude the app in our db query when checking for existing origins.

Comment 2

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/c72ff7f

Comment 3

[Iulian Timis]

Issue is still reproducing in https://marketplace-dev.allizom.org/developers/ on FF25 (Win 7).
Please see screencast http://screencast.com/t/qfpT12cZA

Comment 4

[Rob Hudson [:robhudson]]

Thanks for catching that. Fixed now.
https://github.com/mozilla/zamboni/commit/3498f75

Comment 5

[Jason Smith [:jsmith]]

I need to verify a platform bug in relation to this, so I'll test this by caveat as well on marketplace dev to do two verifications at once.

Comment 6

[krupa raj[:krupa]]

Still doesn't work. See http://cl.ly/image/3g3J0I373X2X

Comment 7

[krupa raj[:krupa]]

whoops, wrong bug

Comment 8

[Jason Smith [:jsmith]]

lgtm - my test app I was using that was a privileged packaged app with an origin specified updating to a privileged packaged app with the same origin was successfully able to be uploaded to marketplace.

I did notice bug 895708 by caveat however testing the update path, but that's likely a different issue.