Write before & after tests for the panel tests

RESOLVED INCOMPLETE

Status

Add-on SDK
General
P3
normal
RESOLVED INCOMPLETE
5 years ago
10 months ago

People

(Reporter: erikvold, Unassigned, Mentored)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

I suspect there are panel tests that do not clean themselves properly, this but is about finding those with before & after tests introduced recently (see bug 892126) and preventing new issues of the same kind from entering the suite.
What specific things are you going to be checking for here?
Priority: -- → P3
Pinging Erik on Dave's question-
Flags: needinfo?(evold)
(In reply to Dave Townsend (:Mossop) from comment #1)
> What specific things are you going to be checking for here?

It looked like there was a panel test that was running without a browser window.  I think we decided to make test that there is a window open before and after every test in another bug tho?
Flags: needinfo?(evold) → needinfo?(dtownsend+bugmail)
(In reply to Erik Vold [:erikvold] [:ztatic] from comment #3)
> (In reply to Dave Townsend (:Mossop) from comment #1)
> > What specific things are you going to be checking for here?
> 
> It looked like there was a panel test that was running without a browser
> window.  I think we decided to make test that there is a window open before
> and after every test in another bug tho?

Yeah bug 863456. The latest patch I have for it causes one test failure on just one platform that I haven't been able to figure out :(
Flags: needinfo?(dtownsend+bugmail)
Whiteboard: [mentor=jsantell@mozilla.com]
(Assignee)

Updated

4 years ago
Mentor: jsantell
Whiteboard: [mentor=jsantell@mozilla.com]
Blocks: 821476
OS: Mac OS X → All
Hardware: x86 → All
https://bugzilla.mozilla.org/show_bug.cgi?id=1399562
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.