892788 - [B2G][l10n][Settings][Storage] "Cancel" and "Change" are not localized when changing default storage

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Sarah Parsons]

Attachment: screenshot

Description: "Cancel" and "Change" are not localized when changing default storage.

Repro Steps:
1) Updated to Leo Build ID: 20130710070204
2) Go to Settings.
3) Scroll down and select Media Storage.
4) Scroll to the bottom and select option to change the default media location.

Actual:
The "Cancel" and "Change" buttons are not localized.

Expected:
User should be able to see options in correct language.

Environmental Variables
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/aaa74e5efaf1
Gaia: 7cdcc46179d198cab11970964b181ede32a5b683
Platform Version: 18.1
RIL Version: 01.01.00.019.138 

Notes:
Repro frequency: 100%

Comment 1

[Sarah Parsons]

This issue is also appearing in Hungarian Build ID: 20130713070207

Environmental Variables
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/f21152a848da
Gaia: 2e711c1fdd2441bda34703cd7d8d3c0f1cc2c396
Platform Version: 18.1

Comment 2

[Fabien Cazenave [:kaze]]

Attachment: link to pull request — l10n fix

Comment 3

[Axel Hecht [:Pike]]

Removing late-l10n keyword as it's picking up existing strings. They're already using in multiple places, too. Thus I'd claim there's little localizer impact.

Once we land this, it'd be good to get QA eyes on it, though.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 777780 [details]
link to pull request — l10n fix

The patch looks good to me, fwiw. I'm not a gaia reviewer though.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 777780 [details]
link to pull request — l10n fix

Thanks for the fix!

master: https://github.com/mozilla-b2g/gaia/commit/799f7a6df44cc2085f7fe697870bc4f842af88f0

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 799f7a6df44cc2085f7fe697870bc4f842af88f0 to:
v1-train: c2096c5e83d5f19a684cc64ec6e5e0bce98d57c3

Comment 7

[dkumar]

Verified,fixed on LEO 1.1 Mozilla RIL
Environmental Variables
Build ID: 20130722070207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/68fb0a2e0114
Gaia: 41d10fb10be6916e6554eb440d9a97130ef23ce0
Platform Version: 18.1
Issue does not reproduce user is able to see "Cancel" and "Change" buttons in localized language.

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: c2096c5e83d5f19a684cc64ec6e5e0bce98d57c3

Comment 9

[mdaniloff]

Fixed in the latest Leo COMM RIL. The "Cancel" and "Change" buttons are localized in the Slovak and Hungarian language.

Environmental Variables
Build ID: 20130801070210
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/aff662053ee8
Gaia: ddb922ed002e88d01f71199da32ff75911b455b2
Platform Version: 18.1
RIL Version: 01.01.00.019.180