Remove useless -D flags 'IMPL_THEBES,_IMPL_NS_GFX,...'

RESOLVED FIXED in mozilla25

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

Trunk
mozilla25
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Some (all?) of these are now useless and they clutter our build arguments. Should be an easy clean up:

http://mxr.mozilla.org/mozilla-central/source/config/config.mk#338
Off that list, only _IMPL_NS_COM, IMPL_XREAPI and IMPL_NS_NET are used in m-c.
Those three could be replaced by a single IMPL_LIBXUL or something.
(Assignee)

Comment 3

5 years ago
Created attachment 774500 [details] [diff] [review]
patch

Since you've already looked at this I'm tentatively asking you to review bug feel free to delegate.
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #774500 - Flags: review?(mh+mozilla)
Comment on attachment 774500 [details] [diff] [review]
patch

Review of attachment 774500 [details] [diff] [review]:
-----------------------------------------------------------------

Most of the files where you're adding DEFINES += -DIMPL_LIBXUL would most probably be fine without it, but with LIBXUL_LIBRARY = 1 in the Makefile instead.

::: netwerk/mime/Makefile.in
@@ +17,5 @@
>  FORCE_STATIC_LIB = 1
>  
>  include $(topsrcdir)/config/rules.mk
>  
> +DEFINES += -DIMPL_LIBXUL

This file contains LIBXUL_LIBRARY=1, no need for this.

::: widget/windows/Makefile.in
@@ +17,5 @@
>  RESFILE		= widget.res
>  MODULE_NAME	= nsWidgetWinModule
>  LIBXUL_LIBRARY = 1
>  
> +DEFINES		+= -DMOZ_UNICODE 

Remove the trailing whitespace while you're here.

::: xpcom/build/Makefile.in
@@ +74,5 @@
>  include $(topsrcdir)/ipc/chromium/chromium-config.mk
>  include $(topsrcdir)/config/rules.mk
>  
>  DEFINES		+= \
> +		-DIMPL_LIBXUL \

This file contains LIBXUL_LIBRARY=1, no need for this.

::: xpcom/io/Makefile.in
@@ +39,5 @@
>  
>  include $(topsrcdir)/config/rules.mk
>  include $(topsrcdir)/ipc/chromium/chromium-config.mk
>  
> +DEFINES		+= -DIMPL_LIBXUL

Likewise.

::: xpcom/threads/Makefile.in
@@ +21,5 @@
>  
>  
>  include $(topsrcdir)/config/rules.mk
>  
> +DEFINES		+= -DIMPL_LIBXUL

Likewise.
Attachment #774500 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 774602 [details] [diff] [review]
patch
Attachment #774500 - Attachment is obsolete: true
Attachment #774602 - Flags: review+
(Assignee)

Comment 6

5 years ago
Created attachment 774604 [details] [diff] [review]
rebased on inbound

Fixed 16 conflicts
Attachment #774602 - Attachment is obsolete: true
Attachment #774604 - Flags: review+
(Assignee)

Updated

5 years ago
Attachment #774604 - Attachment is patch: true
https://hg.mozilla.org/mozilla-central/rev/e6ebdb6069c7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.