892862 - [b2g-bluetooth] Failed to receive system message of Sco connection status changed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Gina Yeh [:gyeh] [:ginayeh]]

Per Arthur, when Sco connection is established/destroyed, we didn't notice by system message with type "bluetooth-sco-status-changed".

The root cause here is that we should add it in dom/messages/SystemMessagePermissionsChecker.jsm for permission check.

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v1): Add SystemMessagePermissionCheck

Eric, please help to review this patch. Thanks.

Comment 2

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 774474 [details] [diff] [review]
Patch 1(v1): Add SystemMessagePermissionCheck

Review of attachment 774474 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nit addressed. Please make sure the debug message won't be enabled before you check it in. Thank you.

::: dom/messages/SystemMessageInternal.js
@@ +43,5 @@
>                    "SystemMessageManager:HandleMessagesDone",
>                    "child-process-shutdown"]
>  
>  function debug(aMsg) {
> +  dump("-- SystemMessageInternal " + Date.now() + " : " + aMsg + "\n");

We should not let this be compiled. Please readd the comment sign.

Comment 3

[Gina Yeh [:gyeh] [:ginayeh]]

(In reply to Eric Chou [:ericchou] [:echou] from comment #2)
> ::: dom/messages/SystemMessageInternal.js
> > +  dump("-- SystemMessageInternal " + Date.now() + " : " + aMsg + "\n");
> 
> We should not let this be compiled. Please readd the comment sign.

Agree. I accidentally added thie line into patch. :(

Comment 4

[Gina Yeh [:gyeh] [:ginayeh]]

try:
https://tbpl.mozilla.org/?tree=Try&rev=2c8541038a2e

Comment 5

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Final patch, r=echou

Comment 6

[Gina Yeh [:gyeh] [:ginayeh]]

http://hg.mozilla.org/projects/birch/rev/8e88c01ceb0a

Comment 7

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Final patch, part 2, r=echou

Please help to check this patch. Thanks.

Comment 8

[Gina Yeh [:gyeh] [:ginayeh]]

Push patch 2 to birch:

http://hg.mozilla.org/projects/birch/rev/403531e4ebdf

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8e88c01ceb0a

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/403531e4ebdf