892908 - [STK]When the user input 'ENTER KEY' in the GET_INPUT of the STK Command, the B2G is reboot.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Leo]

When the user input 'ENTER KEY' in the GET_INPUT of the the STK Command, the B2G process is reboot. 

Gaia : 0d5a9a7577f16b6a72a982148c6f509ee1714ea2
Gecko : 499c1f8ea7ad0cdaa7086214278e2944b8a2ea33

Frequence rate : 100%

Comment 1

[:gerard-majax]

I'm reproducing this :)

Comment 2

[:gerard-majax]

logcat shows:
E/GeckoConsole(  717): [JavaScript Error: "[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/DOMRequestHelper.jsm :: DOMRequestIpcHelperMessageListener.prototype.destroy :: line 85"  data: no]" {file: "resource://gre/modules/DOMRequestHelper.jsm" line: 85}]

Also, putting gdb on all running process, there seem to be no segfault or crash. And while homescreen and settings process are restarted, the b2g process itself keeps the same pid.

Comment 3

[:gerard-majax]

In the end this was quite trivial. Discussing with :etienne, he pointed me at old similar issues. What happens here is that there is a <form> with no submit. Hence, when tapping the Enter key, the user triggers onsubmit, which in the case of no submit action defined decides to reload the application.

And STK code lives in system application.

Comment 4

[:gerard-majax]

Attachment: Link to Github https://github.com/mozilla-b2g/gaia/pull/10944

Please find attached a link to Github pull request https://github.com/mozilla-b2g/gaia/pull/10944

Comment 5

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 774637 [details]
Link to Github https://github.com/mozilla-b2g/gaia/pull/10944

r+ but since this issue can happen with other forms too, I suggest to modify all forms under 'icc-view'

Comment 6

[:gerard-majax]

Could you please merge this one ? Thanks !

Comment 7

[Ryan VanderMeulen [:RyanVM]]

PUSH ZEE BUTTON!
https://github.com/mozilla-b2g/gaia/commit/fa6a7d2530ce4a383ee440d8197930afbf03b3f9

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted fa6a7d2530ce4a383ee440d8197930afbf03b3f9 to:
v1-train: 210107c8bee0b6b4de05c65d9956d7b3028ce763

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 210107c8bee0b6b4de05c65d9956d7b3028ce763