Closed Bug 892925 Opened 11 years ago Closed 10 years ago

[ko] Broken icon for searchplugin danawa-kr.xml (다나와) on Firefox for Android

Categories

(Mozilla Localizations :: ko / Korean, defect)

Product:
Mozilla Localizations
Component:
ko / Korean
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: flod, Assigned: flod)

References

(
URL
)

Details

Attachments

(3 files, 5 obsolete files)

Screenshot of searchplugin's missing icon
68.85 KB, image/png
Details
danawa.ico
1.12 KB, image/x-icon
Details
Danawa patch v1.3
15.78 KB, patch
flod
: review-
Details | Diff | Splinter Review 
The current image in danawa-kr.xml (see URL) is not displayed on Android.

The image must be encoded in base64 and must not contain % characters (this last part is a problem only happening on mobile, not Firefox for desktop).
Can you please check Firefox too? Is the icon displayed? 
I see you're using the same data:image/x-icon there
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ko/file/b5365ce8c94c/browser/searchplugins/danawa-kr.xml
Attached file 32px icon (obsolete) — 
32x32 PNG icon, obtained enlarging the original icon (16x16).

If you don't find anything better this should work.
(In reply to Francesco Lodolo [:flod] from comment #1)
> Can you please check Firefox too? Is the icon displayed? 
> I see you're using the same data:image/x-icon there
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/ko/file/b5365ce8c94c/
> browser/searchplugins/danawa-kr.xml

I'm pretty sure that just works through the magic of %XX escapes. They're taking more space than base64 for binary data, but that's all.
Yep, it works and I realized I took the wrong icon.
Attachment #774577 - Attachment is obsolete: true
Attached file 32px icon (obsolete) — 
Not sure where you've got the old icon, but this is the best I can come up with.
The only thing I found while searching for the icon is bug 790851.
Flags: needinfo?(pillarlee16)
Blocks: 882093
CCing a few more people from the Korean team.
Attached patch danawa-patch (obsolete) — — Splinter Review 
Sorry for my late response for this bug. I attached patch for this.
Attachment #785504 - Flags: review?(stas)
Flags: needinfo?(pillarlee16)
Assignee: nobody → channy
Component: General → ko / Korean
Product: Firefox for Android → Mozilla Localizations
QA Contact: channy
Version: Trunk → unspecified
QA Contact: channy → hyeonseok
Comment on attachment 785504 [details] [diff] [review]
danawa-patch

Review of attachment 785504 [details] [diff] [review]:
-----------------------------------------------------------------

The patch is not going to work. 

As explained in the first comment, the image must be 32x32 pixels and be encoded in base64 (without % characters).
Attachment #785504 - Flags: review?(stas) → review-
Attached patch danawa-patch v1.1 (obsolete) — — Splinter Review 
I fixed icon size with base64 encoding. Would you review again?
Attachment #785504 - Attachment is obsolete: true
Attachment #785508 - Flags: review?
Comment on attachment 785508 [details] [diff] [review]
danawa-patch v1.1

Review of attachment 785508 [details] [diff] [review]:
-----------------------------------------------------------------

I tried the patched searchplugin but it's still not working (no image displayed).

I think this is the problem
https://bugzilla.mozilla.org/show_bug.cgi?id=885079#c7

The icon must be 32x32, but the tag must still say 16x16
<Image width="16" height="16">

I'll also have to clear with Axel if I'm entitled to give a r+ ;-)
Anyway, always put a name in the review field (for now you can put mine).
Attachment #785508 - Flags: review? → review-
Flags: needinfo?(l10n)
Got confirmation from Axel on IRC, please set me as reviewer for the next patch.
Flags: needinfo?(l10n)
Flags: needinfo?(channy)
Depends on: 914064
No longer depends on: 914064
Flags: needinfo?(channy)
:channy
You cleared the needinfo but the problem in still there.
Fixed as part of bug 939834
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ko/rev/aff275e0b308

Please verify with next builds that both danawa-kr and daum-kr show up with the right icon.
Assignee: channy → francesco.lodolo
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attached image danawa.ico — 
I got new icon from Danawa Inc. from 14 x 14 to 16 x 16 size. 

> 2014년 1월 20일 오후 6:21, 정세희 <mshuman@danawa.com>님이 작성:
>
>    안녕하세요 운영자님..
>    전 가격비교 쇼핑포털 (주)다나와의 마케팅본부를 맡고 있는 정세희라고 합니다.
>    새로운 아이콘 파일을 보내 드립니다.
> 
>      	정세희 (SeHee Jeong)
>    ㈜다나와 / 마케팅본부 / 부장
>    Address : 서울시 양천구 목 1동 923-14 드림타워 5층
>    Phone : 1688-2450 (내선:309) / Mobile : 011-410-3410 / Fax : 1688-2451
>    E-mail : mshuman@danawa.com / MSN messenger : mshuman@danawa.com
>    Blog : http://blog.danawa.com/mshuman  
>    행복쇼핑의 시작 ! 다나와 (가격비교) - Danawa.com
Attachment #774583 - Attachment is obsolete: true
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Danawa.ico patch v1.2 (obsolete) — — Splinter Review 
Patch for icon resizing to 16x16 with new icon
Attachment #8367869 - Flags: review?(francesco.lodolo)
Attachment #8367869 - Attachment description: danawa.txt → Danawa.ico patch v1.2

        Attachment #785508 -
        Attachment is obsolete: true

        Attachment #8367869 -
        Attachment is obsolete: true

        Attachment #8367869 -
        Flags: review?(francesco.lodolo)

        Attachment #8367871 -
        Flags: review?(francesco.lodolo)

    
    

    
  
Comment on attachment 8367871 [details] [diff] [review]
Danawa patch v1.3

Review of attachment 8367871 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Channy, not sure why you're reopening this bug.

1. This problem affected only mobile, and you're changing all icons (Firefox, Thunderbird, Firefox for Android).
2. Mobile requires a 32x32px icon (soon 256x256px). 16px is not going to work and there's already a 32px icon in use

        Attachment #8367871 -
        Flags: review?(francesco.lodolo) → review-

    
    

    
  
I'm closing this one again. Searchplugin on mobile has been fixed with the image you provided (see comment 14).

If you want to update Firefox or Thunderbird current icon, that's fine but please file a new bug.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 10 years ago
Resolution: --- → FIXED

    
    

    
  
(In reply to Francesco Lodolo [:flod] from comment #20)
> I'm closing this one again. Searchplugin on mobile has been fixed with the
> image you provided (see comment 14).
> 
> If you want to update Firefox or Thunderbird current icon, that's fine but
> please file a new bug.

Yes. I'll file new bug for new icon got from Danawa. Sorry for confusing.

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: