Closed Bug 892940 Opened 9 years ago Closed 9 years ago

Obsoleting old patches doesn't work when using interactive mode

Categories

(Developer Services :: Mercurial: bzexport, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

Details

Attachments

(1 file, 1 obsolete file)

$ hg bzexport -e -i
saved edited form in .hg/last_bzexport.txt
No changes made; continue with current values (y/n)? y
Attach patch (y/n)? y
2013-07-12_10-22-56_r113+.diff uploaded as https://bugzilla.mozilla.org/attachment.cgi?id=774547&action=edit
Obsolete patch https://bugzilla.mozilla.org/attachment.cgi?id=774536 (2013-07-12_10-22-56_r113+.diff) - test (y/n)? y
Obsolete patch https://bugzilla.mozilla.org/attachment.cgi?id=774537 (2013-07-12_10-22-56_r113+.diff) - test (y/n)? y
Obsolete patch https://bugzilla.mozilla.org/attachment.cgi?id=774539 (2013-07-12_10-22-56_r113+.diff) - test (y/n)? y
Obsolete patch https://bugzilla.mozilla.org/attachment.cgi?id=774541 (2013-07-12_10-22-56_r113+.diff) - test (y/n)? y

...and yet they were not obsoleted.
Attached patch Patch v1Splinter Review
Un-invert the interactive mode confirmation prompt for obsoleting patches.
(Attaching again to test obsoletion).
Attachment #774586 - Flags: review?(sphink)
Attachment #774584 - Attachment is obsolete: true
Comment on attachment 774586 [details] [diff] [review]
Patch v1

Review of attachment 774586 [details] [diff] [review]:
-----------------------------------------------------------------

Just a week ago, I found another place where I had gotten == and != backwards (in some buildbot stuff, not here.) I blame brain rot.

Thanks!
Attachment #774586 - Flags: review?(sphink) → review+
http://hg.mozilla.org/users/tmielczarek_mozilla.com/bzexport/rev/e90b3081344d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Other Applications → Developer Services
You need to log in before you can comment on or make changes to this bug.