892940 - Obsoleting old patches doesn't work when using interactive mode

Status: RESOLVED FIXED

(Developer Services :: Mercurial: bzexport, defect)

Description

[Ed Morley [:emorley]]

$ hg bzexport -e -i
saved edited form in .hg/last_bzexport.txt
No changes made; continue with current values (y/n)? y
Attach patch (y/n)? y
2013-07-12_10-22-56_r113+.diff uploaded as https://bugzilla.mozilla.org/attachment.cgi?id=774547&action=edit
Obsolete patch https://bugzilla.mozilla.org/attachment.cgi?id=774536 (2013-07-12_10-22-56_r113+.diff) - test (y/n)? y
Obsolete patch https://bugzilla.mozilla.org/attachment.cgi?id=774537 (2013-07-12_10-22-56_r113+.diff) - test (y/n)? y
Obsolete patch https://bugzilla.mozilla.org/attachment.cgi?id=774539 (2013-07-12_10-22-56_r113+.diff) - test (y/n)? y
Obsolete patch https://bugzilla.mozilla.org/attachment.cgi?id=774541 (2013-07-12_10-22-56_r113+.diff) - test (y/n)? y

...and yet they were not obsoleted.

Comment 1

[Ed Morley [:emorley]]

Attachment: Un-invert the interactive mode confirmation prompt for obsoleting patches;

Comment 2

[Ed Morley [:emorley]]

Attachment: Patch v1

Un-invert the interactive mode confirmation prompt for obsoleting patches.
(Attaching again to test obsoletion).

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 774586 [details] [diff] [review]
Patch v1

Review of attachment 774586 [details] [diff] [review]:
-----------------------------------------------------------------

Just a week ago, I found another place where I had gotten == and != backwards (in some buildbot stuff, not here.) I blame brain rot.

Thanks!

Comment 4

[Ed Morley [:emorley]]

http://hg.mozilla.org/users/tmielczarek_mozilla.com/bzexport/rev/e90b3081344d