892947 - [fig] Update ReaderList Status when removed via ContextMenu

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Mark Capella [:capella]]

Attachment: bugreader WIP (v1)

This completes some logic in fig. When removing items from the Reading List panel by context menu |Remove|, this updates status of the In/Out ReaderMode icon and the ReaderList (Has/Has no items) icon in the readerlist panel (floating strip on the bottom of the screen).

Most of this was originally put into place in bug 802093 and bug 800899.

Comment 1

[Lucas Rocha (:lucasr)]

Comment on attachment 774591 [details] [diff] [review]
bugreader WIP (v1)

Review of attachment 774591 [details] [diff] [review]:
-----------------------------------------------------------------

Looks right overall, but needs the suggested fix.

::: mobile/android/base/home/HomeListView.java
@@ +134,5 @@
>              rowId = cursor.getInt(cursor.getColumnIndexOrThrow(Bookmarks._ID));
>              url = cursor.getString(cursor.getColumnIndexOrThrow(URLColumns.URL));
>              title = cursor.getString(cursor.getColumnIndexOrThrow(URLColumns.TITLE));
> +            inReadingList = cursor.getInt(cursor.getColumnIndexOrThrow(Bookmarks.PARENT)) ==
> +                Bookmarks.FIXED_READING_LIST_ID;

You should not assume this column is always available here. Get column index, if it returns != -1 then you set inReadingList explicitly. Set inReadingList to false otherwise.

Comment 2

[Mark Capella [:capella]]

Attachment: Patch (v2)

Oh! I get that! ( Thanks :-) )

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 774739 [details] [diff] [review]
Patch (v2)

Review of attachment 774739 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: mobile/android/base/home/HomeFragment.java
@@ +170,5 @@
> +                            e = GeckoEvent.createBroadcastEvent("Reader:ListCountUpdated", Integer.toString(aCount));
> +                            GeckoAppShell.sendEventToGecko(e);
> +                        }
> +
> +                       Toast.makeText(activity, messageId, Toast.LENGTH_SHORT).show();

nit: indentation is a bit off here.

Comment 4

[Mark Capella [:capella]]

Nit picked / all gone

http://hg.mozilla.org/projects/fig/rev/f3f76c0ea2ce

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f3f76c0ea2ce