Closed Bug 892947 Opened 9 years ago Closed 8 years ago

[fig] Update ReaderList Status when removed via ContextMenu

Categories

(Firefox for Android Graveyard :: Reader View, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: capella, Assigned: capella)

References

Details

(Whiteboard: [fixed-fig])

Attachments

(2 files)

This completes some logic in fig. When removing items from the Reading List panel by context menu |Remove|, this updates status of the In/Out ReaderMode icon and the ReaderList (Has/Has no items) icon in the readerlist panel (floating strip on the bottom of the screen).

Most of this was originally put into place in bug 802093 and bug 800899.
Attachment #774591 - Flags: feedback?(lucasr.at.mozilla)
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Comment on attachment 774591 [details] [diff] [review]
bugreader WIP (v1)

Review of attachment 774591 [details] [diff] [review]:
-----------------------------------------------------------------

Looks right overall, but needs the suggested fix.

::: mobile/android/base/home/HomeListView.java
@@ +134,5 @@
>              rowId = cursor.getInt(cursor.getColumnIndexOrThrow(Bookmarks._ID));
>              url = cursor.getString(cursor.getColumnIndexOrThrow(URLColumns.URL));
>              title = cursor.getString(cursor.getColumnIndexOrThrow(URLColumns.TITLE));
> +            inReadingList = cursor.getInt(cursor.getColumnIndexOrThrow(Bookmarks.PARENT)) ==
> +                Bookmarks.FIXED_READING_LIST_ID;

You should not assume this column is always available here. Get column index, if it returns != -1 then you set inReadingList explicitly. Set inReadingList to false otherwise.
Attachment #774591 - Flags: feedback?(lucasr.at.mozilla) → feedback+
Attached patch Patch (v2)Splinter Review
Oh! I get that! ( Thanks :-) )
Attachment #774739 - Flags: review?(lucasr.at.mozilla)
Comment on attachment 774739 [details] [diff] [review]
Patch (v2)

Review of attachment 774739 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

::: mobile/android/base/home/HomeFragment.java
@@ +170,5 @@
> +                            e = GeckoEvent.createBroadcastEvent("Reader:ListCountUpdated", Integer.toString(aCount));
> +                            GeckoAppShell.sendEventToGecko(e);
> +                        }
> +
> +                       Toast.makeText(activity, messageId, Toast.LENGTH_SHORT).show();

nit: indentation is a bit off here.
Attachment #774739 - Flags: review?(lucasr.at.mozilla) → review+
Whiteboard: [fixed-fig]
https://hg.mozilla.org/mozilla-central/rev/f3f76c0ea2ce
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.