892950 - error-network message can use better English

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Axel Hecht [:Pike]]

We introduced the following string in video.en-US.properties:

A network error caused the video failed to download.

That could use some English love.

https://github.com/mozilla-b2g/gaia/blob/master/apps/video/locales/video.en-US.properties#L43

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Chris,

This is a trivial bug and good for a starter. Would you mind to provide proper English wordings?

Comment 2

[Ram Dayal Vaishnav [:ram]]

I have set this string to "Video could not be downloaded because of network error."
If you propose some better string, I will commit it again. Otherwise if this is fine, kindly check my pull request : https://github.com/mozilla-b2g/gaia/pull/14913

Comment 3

[Ram Dayal Vaishnav [:ram]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/14913

pull request : https://github.com/mozilla-b2g/gaia/pull/14913

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8350966 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/14913

This sentence looks good to me. Thanks for this patch. And forget to rename the string entity name before merging to master.

Comment 5

[Ram Dayal Vaishnav [:ram]]

(In reply to John Hu [:johnhu] from comment #4)
> Comment on attachment 8350966 [details] [review]
> https://github.com/mozilla-b2g/gaia/pull/14913
> 
> This sentence looks good to me. Thanks for this patch. And forget to rename
> the string entity name before merging to master.

1. I didn't get what you mean by the last sentence? 
2. Also tell me when will this bug be set to Resolved?
3. Please set my name as Asignee

Anyways, its my first Patch, Feeling Awesome now :)

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

Oh, sorry.

I think I am wrong about string entity. We have a page about l10n changing: https://developer.mozilla.org/en-US/docs/Making_String_Changes

At first, I feel we should change the l10n-id. But if this is only for English, we may don't need to do so.

May you have the authority to merge the code to master?? If no, I may help you to do it.

Comment 7

[Ram Dayal Vaishnav [:ram]]

Got the point. Now please tell me how this will be merged with the master?

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

May you see the merge button in your PR??

Comment 9

[Ram Dayal Vaishnav [:ram]]

(In reply to John Hu [:johnhu] from comment #8)
> May you see the merge button in your PR??

Nope

Comment 10

[John Hu [:johnhu][:johu][:醬糊小弟]]

mreged to master:
https://github.com/mozilla-b2g/gaia/commit/f91bbaf36bdf5be2779769c8cc14607dd5661c2d

Comment 11

[Ram Dayal Vaishnav [:ram]]

John, I have a doubt. In my profile at "https://bugzilla.mozilla.org/user_profile" it still showing me "Patches submitted : 0" only. I thought it will show me 1 patch submitted for above Pull Request.

Comment 12

[John Hu [:johnhu][:johu][:醬糊小弟]]

Hi Ram,

That's for the patch uploaded to bugzilla not for github. We, gaia devs, all use github PR to get the number. You may find your record at https://github.com/gurumukhi.

Comment 13

[Chris Lam]

Hey all,

How about "The video could not be downloaded because of a network error" instead of "Video could not be downloaded because of network error."

I have made the changes if that is ok.

Comment 14

[John Hu [:johnhu][:johu][:醬糊小弟]]

Hi Ram,

May you help to revise your PR to the text suggested by our UX as per comment 13?? And I can help you to revert the previous patch and land the new PR again.

Comment 15

[Ram Dayal Vaishnav [:ram]]

ok i will do that

Comment 16

[Ram Dayal Vaishnav [:ram]]

ok i will do that

Comment 17

[Ram Dayal Vaishnav [:ram]]

Attachment: PR

Comment 18

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8356684 [details] [review]
PR

Thanks for that. Although we should not use two patch inside a bug, it is just a text change. we can accept it and merge it.

Comment 19

[John Hu [:johnhu][:johu][:醬糊小弟]]

The text had updated to the text at comment 13. Thank you, Chris.
merged to master:
https://github.com/mozilla-b2g/gaia/commit/687dd3b805c024a55a64a4d0bb79763a831766d2