892964 - Rewrite DrawTargetCG::MaskSurface to avoid using FillRect()

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Attachment: Rewrite DrawTargetCG::MaskSurface to avoid using FillRect()

With FillRect we were setting the transform twice.

The patch looks really bad because I needed to move the implementation of MaskSurface so that it was below the helper methods. 

The actual change is:

-  FillRect(Rect(aOffset.x, aOffset.y, size.width, size.height), aSource, aDrawOptions);
-
+  if (isGradient(aSource)) {
+    // we shouldn't need to clip to an additional rectangle
+    // as the cliping to the mask should be sufficient.
+    DrawGradient(cg, aSource);
+  } else {
+    SetFillFromPattern(cg, mColorSpace, aSource);
+    CGContextFillRect(cg, CGRectMake(aOffset.x, aOffset.y, size.width, size.height));
+  }

This also avoids setting up other state like alpha and the unboundness fixer twice.

Comment 1

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6a859782966e