Closed
Bug 8930
Opened 25 years ago
Closed 25 years ago
Use ns<SvcImpl>::GetCID() instead of kSvcMumble_CID
Categories
(Core :: XPCOM, defect, P3)
Tracking
()
RESOLVED
WONTFIX
M15
People
(Reporter: brendan, Assigned: dp)
Details
dp asked me to bug him about this: Brendan Eich wrote: > > > servmgr->GetService(kComponentManagerCID, nsComponentManager::GetIID(),..); > > Can't the first arg be (and wouldn't it be better if it were) > nsComponentManager::GetCID() ? Yes. In fact, we could do this for all static objects comming out of xpcom like Allocator. I will keep this in mind. Would be better if you file a bug on me. dp
Comment 1•25 years ago
|
||
Two points: 1. For services, I think this would be a good thing, but I would call it GetSID instead. 2. For class IDs, this is a bad thing, because class IDs should never be in interface header files. They should be stored somewhere else -- some file that reflects all the current class' implementation CIDs. Remember that these can change from release to release, upgrade to upgrade.
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M10
Assignee | ||
Updated•25 years ago
|
Target Milestone: M10 → M15
Updated•25 years ago
|
QA Contact: beppe → dp
Assignee | ||
Comment 2•25 years ago
|
||
I dont think we are ever going to fix this. As warren points out, CID cannot be a function of the interface. Putting it on a class seems awkward too.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•