Use ns<SvcImpl>::GetCID() instead of kSvcMumble_CID

RESOLVED WONTFIX

Status

()

Core
XPCOM
P3
normal
RESOLVED WONTFIX
19 years ago
18 years ago

People

(Reporter: brendan, Assigned: Suresh Duddi (gone))

Tracking

Trunk
All
Other
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

19 years ago
dp asked me to bug him about this:

Brendan Eich wrote:
>
> > servmgr->GetService(kComponentManagerCID, nsComponentManager::GetIID(),..);
>
> Can't the first arg be (and wouldn't it be better if it were)
> nsComponentManager::GetCID() ?

Yes. In fact, we could do this for all static objects comming out of
xpcom like Allocator.

I will keep this in mind. Would be better if you file a bug on me.

dp

Comment 1

19 years ago
Two points:

1. For services, I think this would be a good thing, but I would call it GetSID
instead.

2. For class IDs, this is a bad thing, because class IDs should never be in
interface header files. They should be stored somewhere else -- some file that
reflects all the current class' implementation CIDs. Remember that these can
change from release to release, upgrade to upgrade.
(Assignee)

Updated

19 years ago
Status: NEW → ASSIGNED
Target Milestone: M10
(Assignee)

Updated

19 years ago
Target Milestone: M10 → M15

Updated

19 years ago
QA Contact: beppe → dp
(Assignee)

Comment 2

18 years ago
I dont think we are ever going to fix this. As warren points out, CID cannot be
a function of the interface. Putting it on a class seems awkward too.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.