893081 - add buildbot-configs for tcanvasmark

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

on android we are adding a new talos test, this is call tcanvasmark.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: add tcanvasmark to the buildbot configs for mobile (1.0)

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: updated canvasmark to run on desktop and mobile (1.0)

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 774824 [details] [diff] [review]
updated canvasmark to run on desktop and mobile (1.0)

Review of attachment 774824 [details] [diff] [review]:
-----------------------------------------------------------------

r- simply because I bitrotted you last night. fix is easy just needs doing. also be sure you have added it to graphserver for androids new test.  I'm out today so follow-up patch to aki or armen is best

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: updated canvasmark to run on desktop and mobile (2.0)

updated for bitrot!

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 777314 [details] [diff] [review]
updated canvasmark to run on desktop and mobile (2.0)

Review of attachment 777314 [details] [diff] [review]:
-----------------------------------------------------------------

r+ if you fix this to be the not-mozpool pandas as mentioned below.

::: mozilla-tests/mobile_config.py
@@ +125,5 @@
>      },
> +    'remote-tcanvasmark': {
> +        'enable_by_default': False,
> +        'suites': GRAPH_CONFIG + ['--activeTests', 'tcanvasmark', '--noChrome'],
> +        'options': (TALOS_REMOTE_FENNEC_OPTS, ANDROID),

this has to be ANDROID_NOT_MOZPOOL instead of ANDROID.

@@ +774,4 @@
>  BRANCHES['mozilla-central']['pgo_platforms'] = []
>  BRANCHES['mozilla-central']['platforms']['android']['enable_debug_unittests'] = True
>  BRANCHES['mozilla-central']['remote-tsvgx_tests'] = (1, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID_NOT_MOZPOOL)
> +BRANCHES['mozilla-central']['remote-tcanvasmark_tests'] = (1, True, TALOS_REMOTE_FENNEC_OPTS, ANDROID)

same here

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

http://hg.mozilla.org/build/buildbot-configs/rev/afb83a1932c6

Comment 7

[Rail Aliiev [:rail]]

In production

Comment 8

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

(In reply to Rail Aliiev [:rail] from comment #7)
> In production

anything left to do here?