Closed
Bug 893151
Opened 11 years ago
Closed 11 years ago
when a private window is active, and pb is supported, and the isPrivate option is not provided, then the default should be to open in the active window
Categories
(Add-on SDK Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Assigned: evold)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
I was updating https://github.com/erikvold/view-page-source-in-tab-jetpack when I noticed this.
Assignee | ||
Updated•11 years ago
|
Attachment #774892 -
Flags: review?(rFobic)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → evold
Comment 3•11 years ago
|
||
Comment on attachment 774892 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1100 Thanks!
Attachment #774892 -
Flags: review?(rFobic) → review+
Comment 4•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/7610c1ac647a6ce3c7583ec2e3829344b9a6ae4e Bug 893151 - when a private window is active, and pb is supported, and the isPrivate option is not provided, then the default should be to open in the active window https://github.com/mozilla/addon-sdk/commit/20e5634d718a67ab0af1a4d29449d47f3c61056d Merge pull request #1100 from erikvold/893151 Bug 893151 - when a private window is active, and pb is supported, and the isPrivate option is not provided, then the default should be to open in the active window r=@gozala
Depends on: 893938
Depends on: 893940
Depends on: 897683
You need to log in
before you can comment on or make changes to this bug.
Description
•