893165 - /id/newsletter formatting

Status: VERIFIED FIXED

(www.mozilla.org :: Newsletters, defect)

Description

[Jessilyn Davis]

Attachment: screenshot

See attached screenshot.

The spacing looks funky in the title (and pushes the form further down = less likely for peeps to fill out the form)

Comment 1

[Dan Poirier [:dpoirier]]

The issue is that in the header 'Read all about it in our <span>newsletter</span>', the <span> and </span> each seem to be causing a line break. In languages like Indonesian where the word order was changed, e.g.:

    Baca selengkapnya di <span>nawala</span> kami

this is breaking the header up into three short lines.

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/bdeb59f7363510726aa54a9801b56ac8ed44f09e
Bug 893165 - /id/newsletter formatting

The issue was that in the header 'Read all about it in our
<span>newsletter</span>', the <span> and </span> each were causing a
line break. In languages like Indonesian where the word order was
changed, e.g.:

    Baca selengkapnya di <span>nawala</span> kami

this was breaking the header up into three short lines.

It turned out that header spans were being styled in newsletter.less
as "display: block". Getting rid of that solves the problem.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/fb26a22df8788206b23ed046822639effad9c5e8
Bug 893165: Turn off specialness of newsletter span

In the headline on the /newsletter page, turn off the special styling
of the span tag. We'd rather just remove the span tag from the text,
but that would invalidate all the existing translations.

https://github.com/mozilla/bedrock/commit/b96d40426efe1584df31c45446471b0b19af42ab
Merge pull request #1089 from dpoirier/bug-893165-neutralize-span

Bug 893165: Turn off specialness of newsletter span

Comment 4

[raymond [:retornam] (inactive)]

fixed on dev https://www.allizom.org/id/newsletter/

Comment 5

[Jessilyn Davis]

Beautiful on prod! :D