893219 - Missing attributes in ES results cause front page marketplace crash

Status: VERIFIED FIXED

(Marketplace Graveyard :: API, defect, P1)

Description

[Jeremy Orem [:oremj]]

https://github.com/mozilla/zamboni/blob/89a0e6d6e22a91305501064d6e8af07d884a8568/mkt/webapps/utils.py#L180

If any of those attrs are not returned in the ES response, the api will return 500 and the entire marketplace front page will fail.

Traceback:

/api/v1/fireplace/search/featured/: AttributeError 
['  File "/data/mkt.prod/www/marketplace.firefox.com/deploy-zamboni-prod-20130712214135-89a0e6d6e2/venv/lib/python2.6/site-packages/tastypie/resources.py", line 192, in wrapper\n    response = callback(request, *args, **kwargs)\n', '  File "/data/mkt.prod/www/marketplace.firefox.com/deploy-zamboni-prod-20130712214135-89a0e6d6e2/venv/lib/python2.6

Stacktrace (most recent call last):

  File "tastypie/resources.py", line 192, in wrapper
    response = callback(request, *args, **kwargs)
  File "tastypie/resources.py", line 397, in dispatch_list
    return self.dispatch('list', request, **kwargs)
  File "mkt/api/base.py", line 97, in dispatch
    .dispatch(request_type, request, **kwargs))
  File "tastypie/resources.py", line 427, in dispatch
    response = method(request, **kwargs)
  File "mkt/search/api.py", line 110, in get_list
    page['objects'] = [self.full_dehydrate(bundle) for bundle in objs]
  File "tastypie/resources.py", line 662, in full_dehydrate
    bundle = self.dehydrate(bundle)
  File "mkt/search/api.py", line 123, in dehydrate
    request=bundle.request))
  File "mkt/webapps/utils.py", line 183, in es_app_to_dict
    data = dict(zip(attrs, attrgetter(*attrs)(obj)))
  File "elasticutils/__init__.py", line 1809, in __getattr__
    raise AttributeError

Comment 1

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/8cab70e

Comment 2

[Victor Carciu]

Can you please add some STRs to this bug or mark it as [qa-] ?

Comment 3

[Rob Hudson [:robhudson]]

Added a bit more: https://github.com/mozilla/zamboni/commit/216a58d

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

marketplace-dev is/has been looking good, since:

[11:26:50.259] GET https://marketplace-dev.allizom.org/ [HTTP/1.1 200 OK 133ms]