893297 - Icon problem when installing an app from within another app (yo dawg)

Status: RESOLVED FIXED

(Firefox Graveyard :: Webapp Runtime, defect)

Description

[Marco Castelluccio [:marco]]

webapprt/WebappsHandler.jsm allows apps installation from within an app. The installation works fine if a custom icon is specified in the manifest file, but when an icon is not specified the installer code tries to use chrome://browser/skin/webapps-64.png, that isn't present for the webrt.

We could:
A) Move the icon to chrome://global
B) (hacky) Modify the manifest on-the-fly adding the icon as chrome://webapprt/something

I don't know how this kind of URLs works, so probably there are other solutions.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

We could also copy the icon to webapprt/, but I'd rather share the resource between Firefox and the runtime by putting it in Toolkit.  We already do that for some images used by both the classic and the Metro versions of Firefox (f.e. chrome://global/skin/icons/warning-16.png).

mossop: does that seem reasonable to you?

Comment 2

[Dave Townsend [:mossop]]

(In reply to Myk Melez [:myk] [@mykmelez] from comment #1)
> We could also copy the icon to webapprt/, but I'd rather share the resource
> between Firefox and the runtime by putting it in Toolkit.  We already do
> that for some images used by both the classic and the Metro versions of
> Firefox (f.e. chrome://global/skin/icons/warning-16.png).
> 
> mossop: does that seem reasonable to you?

Sounds fine to me

Comment 3

[Marco Castelluccio [:marco]]

Attachment: move_webapps_icon

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing.

Comment 5

[Marco Castelluccio [:marco]]

Attachment: move_webapps_icon

Rebased, carrying r+.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/00c1c1de3e0f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/00c1c1de3e0f