Icon problem when installing an app from within another app (yo dawg)

RESOLVED FIXED in Firefox 25

Status

RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: marco, Assigned: marco)

Tracking

Trunk
Firefox 25
x86_64
Linux

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
webapprt/WebappsHandler.jsm allows apps installation from within an app. The installation works fine if a custom icon is specified in the manifest file, but when an icon is not specified the installer code tries to use chrome://browser/skin/webapps-64.png, that isn't present for the webrt.

We could:
A) Move the icon to chrome://global
B) (hacky) Modify the manifest on-the-fly adding the icon as chrome://webapprt/something

I don't know how this kind of URLs works, so probably there are other solutions.
We could also copy the icon to webapprt/, but I'd rather share the resource between Firefox and the runtime by putting it in Toolkit.  We already do that for some images used by both the classic and the Metro versions of Firefox (f.e. chrome://global/skin/icons/warning-16.png).

mossop: does that seem reasonable to you?
Flags: needinfo?(dtownsend+bugmail)
(In reply to Myk Melez [:myk] [@mykmelez] from comment #1)
> We could also copy the icon to webapprt/, but I'd rather share the resource
> between Firefox and the runtime by putting it in Toolkit.  We already do
> that for some images used by both the classic and the Metro versions of
> Firefox (f.e. chrome://global/skin/icons/warning-16.png).
> 
> mossop: does that seem reasonable to you?

Sounds fine to me
Flags: needinfo?(dtownsend+bugmail)
(Assignee)

Comment 3

5 years ago
Created attachment 779414 [details] [diff] [review]
move_webapps_icon
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #779414 - Flags: review?(dtownsend+bugmail)
Attachment #779414 - Flags: review?(dtownsend+bugmail) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Needs rebasing.
Keywords: checkin-needed
(Assignee)

Comment 5

5 years ago
Created attachment 782005 [details] [diff] [review]
move_webapps_icon

Rebased, carrying r+.
Attachment #779414 - Attachment is obsolete: true
Attachment #782005 - Flags: review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/00c1c1de3e0f
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/00c1c1de3e0f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.