Closed Bug 893331 Opened 11 years ago Closed 6 years ago

<input type=range> — "Assertion failure: value == minimum (Unsanitized value)"

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86_64
Unspecified
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox-esr60 --- wontfix
firefox59 --- wontfix
firefox60 --- wontfix
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- fixed

People

(Reporter: jruderman, Assigned: bryce)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(4 files)

testcase
129 bytes, text/html
Details
stack
10.77 KB, text/plain
Details
Bug 893331 - Relax assert checking if value is within range for nsRangeFrame. r=TYLin
47 bytes, text/x-phabricator-request
Details | Review
Bug 893331 - Add crashtest to verify assertion doesn't unexpectedly fire. r=TYLin
47 bytes, text/x-phabricator-request
Details | Review
Attached file testcase — 
Assertion failure: value == minimum (Unsanitized value), at layout/forms/nsRangeFrame.cpp:449
Attached file stack — 

          status-firefox59:
          --- → affected

          status-firefox60:
          --- → affected
Flags: in-testsuite?
OS: Mac OS X → Unspecified
Component: DOM: Core & HTML → Layout

    
    

    
  
Looks like just an issue of reserializing a float... We should probably just loosen the assertion?

    
    

    
  
I'm hitting this on Windows while trying to test Shaka player[0] with local builds. The `Angel One (HLS, MP4, multilingual)` video seems to result in the issue, for whatever reason.

:xidorn, you mention relaxing the assert, in what way should it be relaxed/loosened?

[0]: https://shaka-player-demo.appspot.com
Flags: needinfo?(xidorn+moz)

    
    

    
  
Maybe change the assertion to something like `abs(value - minimum) <= 1e-6`...
Flags: needinfo?(xidorn+moz)

    
    

    
  


  
GetValueAsFractionOfRange asserts that input == minimum if the range has maximum
<= minimum. This assert is sane at face value, but floating point rounding
issues can cause it to be triggered when input is essentially minimum.

This changeset relaxes the assertion to check the input is within an epsilon
value of minimum (1e-6).

    
    

    
  
Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/711abaf3cd72
Relax assert checking if value is within range for nsRangeFrame. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/4ac91f9693e2
Add crashtest to verify assertion doesn't unexpectedly fire. r=TYLin

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/711abaf3cd72
https://hg.mozilla.org/mozilla-central/rev/4ac91f9693e2
Status: NEW → RESOLVED
Closed: 6 years ago

          status-firefox65:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Assignee: nobody → bvandyk

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: