Closed
Bug 893336
Opened 13 years ago
Closed 13 years ago
Rename listItemCount to reflect string change
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: flod, Assigned: MarcoZ)
References
Details
Attachments
(1 file)
|
1.84 KB,
patch
|
flod
:
review+
yzen
:
review+
|
Details | Diff | Splinter Review |
https://hg.mozilla.org/mozilla-central/rev/65661cb2a63f
listItemCount = %S items
listItemCount = 1 item;#1 items
This is not supposed to happen once strings have landed on mozilla-central
https://developer.mozilla.org/en-US/docs/Making_String_Changes
Please rename this entity (e.g. listItemsCount)
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #775509 -
Flags: review?(francesco.lodolo)
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → marco.zehe
Status: NEW → ASSIGNED
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 775509 [details] [diff] [review]
Rename listItemCount to reflect string change
Review of attachment 775509 [details] [diff] [review]:
-----------------------------------------------------------------
Not sure I'm entitled to do reviews, but the patch looks good to me.
Attachment #775509 -
Flags: review?(francesco.lodolo) → review+
|
|
Assignee | |
Updated•13 years ago
|
Attachment #775509 -
Flags: review?(yura.zenevich)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 775509 [details] [diff] [review]
Rename listItemCount to reflect string change
Review of attachment 775509 [details] [diff] [review]:
-----------------------------------------------------------------
Looks great!
Attachment #775509 -
Flags: review?(yura.zenevich) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•