Closed Bug 893375 Opened 7 years ago Closed 7 years ago

Make weak map tracing names more useful

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

jlebar is looking at some logs involving weak maps, and for whatever reason when we trace values (in two places) it says "WeakMap entry", which is ambiguous.  I think "WeakMap value" would be better.  Also, "WeakMap Key" should probably be "WeakMap key".
Attached patch rename themSplinter Review
Comment on attachment 775165 [details] [diff] [review]
rename them

I'll make sure this compiles before I land it, but it seems low risk.  The review is mostly about whether you agree with the name change.
Attachment #775165 - Flags: review?(wmccloskey)
Comment on attachment 775165 [details] [diff] [review]
rename them

Review of attachment 775165 [details] [diff] [review]:
-----------------------------------------------------------------

This seems good. What do you think about "WeakMap entry key" and "WeakMap entry value"? I'm just worried that "WeakMap value" is kind of ambiguous when you're not thinking about key/value pairs.
Attachment #775165 - Flags: review?(wmccloskey) → review+
Good idea, I'll do that.  Value is a pretty overloaded term...
There are a few more strings further down the file, in the proxy preserving stuff, that I'll fix up similarly.
https://hg.mozilla.org/mozilla-central/rev/d31e8c2a03a4
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.