893557 - [Settings] On installed keyboard list, add links to their settings page.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Evelyn Hung]

Per bug 891672 and bug 891675, we need a way to link a keyboard app's settings page from Settings app. Web Activity might be a solution but it can't do one-to-one delegation. We need to figure out another way.

Comment 1

[Evelyn Hung]

So just discussed with :timdream f2f, a do-able way is let Settings app use app.launch() to launch the keyboard app and open its settings page. So in the manifest of the keyboard app, the 'launch_path' field should link to its settings page or somehow can navigate to it.

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

v1.2 feature. Nominate for koi+.

Comment 3

[Jan Jongboom [:janjongboom] (inactive)]

Hi Arthur, are you working on this?

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Yes, we've already had a WIP merged to the working branch.
Please check it on https://github.com/RudyLu/gaia/commit/0a8a3baba4c239a77cde3243e33794207cce6f01#commitcomment-3748636.

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master,
bc8c1c962addd419b48ba12c6d8ddabdf9805391

Comment 6

[James Lal [:lightsofapollo]]

backed out as part of the general backout of the 3rd party keyboard customizations (https://github.com/mozilla-b2g/gaia/commit/42aa1e2ccd22e464bffe6b22ee1182cece5dc2dc) Due to b2g-desktop failures (fail to start) https://travis-ci.org/mozilla-b2g/gaia/builds/10571231#L129.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: https://github.com/mozilla-b2g/gaia/commit/f283bf33f37cad5d8c337b43766f4ec53eb406c2

Comment 8

[Ed Morley [:emorley]]

Something in this gaia.json auto-commit:
https://hg.mozilla.org/integration/b2g-inbound/rev/31ca106e662c

...broke the gaia unit tests, eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=27215367&tree=B2g-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=27214598&tree=B2g-Inbound

The auto-commit corresponds to:
https://hg.mozilla.org/integration/gaia-central/pushloghtml?fromchange=c258483698afbf2c2b7f27f8fa16922d0ee48880&tochange=75e0fbd934e2c835db9ecd10ec6b2900b357d53c

So this and the others in that push have been backed out:
https://github.com/mozilla-b2g/gaia/commit/c2f23f132accb38af4a46f9171bc6be25fdb99a1
https://github.com/mozilla-b2g/gaia/commit/9a8098e8a6b86a32da0eef08e507ab689435dfee
https://github.com/mozilla-b2g/gaia/commit/884d0af45bc605c8e943e3080b2a909461795953
https://github.com/mozilla-b2g/gaia/commit/6a653be7c8b34f263342ead2037b4f8f3c2aff0e
https://github.com/mozilla-b2g/gaia/commit/cfcb28b5069054c1ad631c5bf4ed9c2a94e06d8b

Please run the gaia unit tests before pushing if possible! :-)

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: https://github.com/mozilla-b2g/gaia/commit/08901c788a3a4bd3efda5853d7ee9c8f6d04cf50