I've found some cases where the vcard_parser library after parsing has 0 contacts to import so the overlay is not hidden
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Comment on attachment 775583 [details] Patch v1 Looks goot to merge. r+
Attachment #775583 - Flags: review?(sergi.mansilla) → review+
And by 'goot', I mean good.
Merged at be526e2381cdc62dc50b7203385a4650aefd40a7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
leo? requested because in case no contacts are importable in the memory card, the import dialog gets stuck. Pretty low risk and important.
(In reply to Sergi Mansilla from comment #5) > leo? requested because in case no contacts are importable in the memory > card, the import dialog gets stuck. Pretty low risk and important. Please describe what you mean by "stuck". Thanks!
He means frozen, it is not hidden anymore, just killing contacts app
Triage - Leo will take this based on comments 5 and 7. :crdlc - can you check also if this is related to Bug 893411
blocking-b2g: leo? → leo+
Umm interesting, could be, because if vcard_parser library parses and detects some error like non ascii characters or whatever, the result could be zero and the curtain will never hide. I detected it when I tried to import my personal vcard bad formed. Ask to someone to test this patch maybe we can kill two birds with one stone ;) I don't know actually if this expression exists in English jejeje, I mean, one fix for two bugs. Thanks
I was not able to uplift this bug to v1-train. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1-train git cherry-pick -x -m1 be526e2381cdc62dc50b7203385a4650aefd40a7 <RESOLVE MERGE CONFLICTS> git commit
status-b2g-v1.1hd: --- → fixed
You need to log in before you can comment on or make changes to this bug.