893719 - [SD card] Vcard parser should deal with the case: number of contacts is zero

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Cristian Rodriguez (:crdlc)]

I've found some cases where the vcard_parser library after parsing has 0 contacts to import so the overlay is not hidden

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Comment 2

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Comment on attachment 775583 [details]
Patch v1

Looks goot to merge. r+

Comment 3

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

And by 'goot', I mean good.

Comment 4

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Merged at be526e2381cdc62dc50b7203385a4650aefd40a7

Comment 5

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

leo? requested because in case no contacts are importable in the memory card, the import dialog gets stuck. Pretty low risk and important.

Comment 6

[Alex Keybl [:akeybl]]

(In reply to Sergi Mansilla from comment #5)
> leo? requested because in case no contacts are importable in the memory
> card, the import dialog gets stuck. Pretty low risk and important.

Please describe what you mean by "stuck". Thanks!

Comment 7

[Cristian Rodriguez (:crdlc)]

He means frozen, it is not hidden anymore, just killing contacts app

Comment 8

[Wayne Chang [:wchang]]

Triage - Leo will take this based on comments 5 and 7.

:crdlc - can you check also if this is related to  Bug 893411

Comment 9

[Cristian Rodriguez (:crdlc)]

Umm interesting, could be, because if vcard_parser library parses and detects some error like non ascii characters or whatever, the result could be zero and the curtain will never hide. I detected it when I tried to import my personal vcard bad formed. Ask to someone to test this patch maybe we can kill two birds with one stone ;) I don't know actually if this expression exists in English jejeje, I mean, one fix for two bugs. Thanks

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 be526e2381cdc62dc50b7203385a4650aefd40a7
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 11

[Cristian Rodriguez (:crdlc)]

v1-train

https://github.com/mozilla-b2g/gaia/commit/55533c667ed78ba05e0b9616d48043b33308a2c5

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 55533c667ed78ba05e0b9616d48043b33308a2c5