[SD card] Vcard parser should deal with the case: number of contacts is zero

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: crdlc, Assigned: crdlc)

Tracking

unspecified
x86
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

Details

(Whiteboard: [LeoVB+])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I've found some cases where the vcard_parser library after parsing has 0 contacts to import so the overlay is not hidden
(Assignee)

Updated

5 years ago
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 775583 [details]
Patch v1
Attachment #775583 - Flags: review?(sergi.mansilla)
Comment on attachment 775583 [details]
Patch v1

Looks goot to merge. r+
Attachment #775583 - Flags: review?(sergi.mansilla) → review+
And by 'goot', I mean good.
Merged at be526e2381cdc62dc50b7203385a4650aefd40a7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
blocking-b2g: --- → leo?
leo? requested because in case no contacts are importable in the memory card, the import dialog gets stuck. Pretty low risk and important.

Comment 6

5 years ago
(In reply to Sergi Mansilla from comment #5)
> leo? requested because in case no contacts are importable in the memory
> card, the import dialog gets stuck. Pretty low risk and important.

Please describe what you mean by "stuck". Thanks!
(Assignee)

Comment 7

5 years ago
He means frozen, it is not hidden anymore, just killing contacts app
Triage - Leo will take this based on comments 5 and 7.

:crdlc - can you check also if this is related to  Bug 893411
blocking-b2g: leo? → leo+
Flags: needinfo?(crdlc)
(Assignee)

Comment 9

5 years ago
Umm interesting, could be, because if vcard_parser library parses and detects some error like non ascii characters or whatever, the result could be zero and the curtain will never hide. I detected it when I tried to import my personal vcard bad formed. Ask to someone to test this patch maybe we can kill two birds with one stone ;) I don't know actually if this expression exists in English jejeje, I mean, one fix for two bugs. Thanks
Flags: needinfo?(crdlc)
I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 be526e2381cdc62dc50b7203385a4650aefd40a7
  <RESOLVE MERGE CONFLICTS>
  git commit
Flags: needinfo?(crdlc)
status-b2g18: --- → fixed
v1.1.0hd: 55533c667ed78ba05e0b9616d48043b33308a2c5
status-b2g-v1.1hd: --- → fixed

Updated

5 years ago
Whiteboard: [LeoVB+]
You need to log in before you can comment on or make changes to this bug.