Assertion failure: a.isGeneralReg(), at ../ion/shared/CodeGenerator-shared-inl.h:31

RESOLVED FIXED in mozilla25

Status

()

--
critical
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: decoder, Assigned: bhackett)

Tracking

(Blocks: 2 bugs, {assertion, regression, testcase})

Trunk
mozilla25
x86
Linux
assertion, regression, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [jsbugmon:update])

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
The following testcase asserts on mozilla-central revision 18467a85acf6 (run with --fuzzing-safe --ion-eager):


var arr = new Int8Array(100);
function f(a) {
  for(var i=0; i<30; i++) {
    x = a[85.3];
  }
}
f(arr);
(Reporter)

Comment 1

5 years ago
Created attachment 775601 [details]
[crash-signature] Machine-readable crash signature
(Reporter)

Updated

5 years ago
Whiteboard: [jsbugmon:update,bisect]
(Reporter)

Updated

5 years ago
Whiteboard: [jsbugmon:update,bisect] → [jsbugmon:update]
(Reporter)

Comment 2

5 years ago
JSBugMon: Bisection requested, result:
autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   http://hg.mozilla.org/mozilla-central/rev/0670cdaf7e9c
user:        Brian Hackett
date:        Thu Jul 11 15:08:26 2013 -0600
summary:     Bug 891400 - Improve pattern matching on static typed array accesses, r=jandem.

This iteration took 0.973 seconds to run.
(Reporter)

Comment 3

5 years ago
Needinfo from Brian based on comment 2 :)
Flags: needinfo?(bhackett1024)
Blocks: 891400
Keywords: regression
(Assignee)

Updated

5 years ago
Duplicate of this bug: 894727
(Assignee)

Updated

5 years ago
Duplicate of this bug: 893726
(Assignee)

Comment 6

5 years ago
Created attachment 777846 [details] [diff] [review]
patch

convertShiftToMaskForStaticTypedArray can now produce non-int32 indexes, and there was no type policy in place to ensure these were converted to integers.
Assignee: general → bhackett1024
Attachment #777846 - Flags: review?(jdemooij)
Flags: needinfo?(bhackett1024)

Updated

5 years ago
Attachment #777846 - Flags: review?(jdemooij) → review+
Blocks: 349611
https://hg.mozilla.org/mozilla-central/rev/d7af6a55966c
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.