893732 - Assertion failure: a.isGeneralReg(), at ../ion/shared/CodeGenerator-shared-inl.h:31

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Christian Holler (:decoder)]

The following testcase asserts on mozilla-central revision 18467a85acf6 (run with --fuzzing-safe --ion-eager):


var arr = new Int8Array(100);
function f(a) {
  for(var i=0; i<30; i++) {
    x = a[85.3];
  }
}
f(arr);

Comment 1

[Christian Holler (:decoder)]

Attachment: [crash-signature] Machine-readable crash signature

Comment 2

[Christian Holler (:decoder)]

JSBugMon: Bisection requested, result:
autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   http://hg.mozilla.org/mozilla-central/rev/0670cdaf7e9c
user:        Brian Hackett
date:        Thu Jul 11 15:08:26 2013 -0600
summary:     Bug 891400 - Improve pattern matching on static typed array accesses, r=jandem.

This iteration took 0.973 seconds to run.

Comment 3

[Christian Holler (:decoder)]

Needinfo from Brian based on comment 2 :)

Comment 6

[Brian Hackett [Laid off!]]

Attachment: patch

convertShiftToMaskForStaticTypedArray can now produce non-int32 indexes, and there was no type policy in place to ensure these were converted to integers.

Comment 7

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d7af6a55966c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d7af6a55966c