Closed Bug 893791 Opened 6 years ago Closed 6 years ago

B2G RIL: xpcshell tests failed in test_ril_worker_mmi.js

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25
blocking-b2g leo+
Tracking Status
firefox24 --- wontfix
firefox25 --- fixed
b2g18 --- fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix
b2g-v1.1hd --- fixed
b2g-v1.2 --- fixed

People

(Reporter: edgar, Assigned: edgar)

References

Details

Attachments

(1 file)

mozilla-central: 5e191a26d909 (hg)

Failed log as below:
------------------------------------
TEST-UNEXPECTED-FAIL | /data/mercurial/mozilla-central/obj-x86_64-unknown-linux-gnu/_tests/xpcshell/dom/system/gonk/tests/test_ril_worker_mmi.js | "RadioNotAvailable" == null - See following stack:
JS frame :: /data/mercurial/mozilla-central/obj-x86_64-unknown-linux-gnu/_tests/xpcshell/dom/system/gonk/tests/test_ril_worker_mmi.js :: setCallForwardSuccess :: line 345
JS frame :: /data/mercurial/mozilla-central/obj-x86_64-unknown-linux-gnu/_tests/xpcshell/dom/system/gonk/tests/test_ril_worker_mmi.js :: test_sendMMI_call_forwarding_activation :: line 350
JS frame :: /data/mercurial/mozilla-central/testing/xpcshell/head.js :: _run_next_test :: line 1143
JS frame :: /data/mercurial/mozilla-central/testing/xpcshell/head.js :: do_execute_soon/<.run :: line 444
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

TEST-INFO | (xpcshell/head.js) | exiting test

TEST-UNEXPECTED-FAIL | (xpcshell/head.js) | TypeError: invalid 'in' operand error - See following stack:
JS frame :: do_throw@/data/mercurial/mozilla-central/testing/xpcshell/head.js:482
JS frame :: _run_next_test@/data/mercurial/mozilla-central/testing/xpcshell/head.js:1145
JS frame :: do_execute_soon/<.run@/data/mercurial/mozilla-central/testing/xpcshell/head.js:444
Depends on: 883048
In bug 883048, we added a check for |radioState|. So if test cases didn't set |radioState| to |GECKO_RADIOSTATE_READY|, mmi request will always get |GECKO_ERROR_RADIO_NOT_AVAILABLE| error.
Attachment #775665 - Flags: review?(vyang)
Assignee: nobody → echen
Comment on attachment 775665 [details] [diff] [review]
Fix xpcshell tests failed in test_ril_worker_mmi.js, v1

Review of attachment 775665 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)
Attachment #775665 - Flags: review?(vyang) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fe9851ec4198
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Blocks: 913281
This bug fixes the failed test in the xpcshell. To enable xpcshell tests in b2g18 [1], we need to uplift this patch, but need to get approval first. Thanks.

[1] Please see bug 913281.
blocking-b2g: --- → leo?
Block for quality concern about test coverage
blocking-b2g: leo? → leo+
Hi Ryan, the patch can be uplifted to b2g18 directly without conflict, could you help on this? Thanks.
Flags: needinfo?(ryanvm)
I'll take care of it, but I would prefer to take it as a ride-along so as to not spin a full set of builds and tests for a test-only change, if that's OK with you. If you don't want to wait, please set checkin-needed.
Flags: needinfo?(ryanvm)
You need to log in before you can comment on or make changes to this bug.