Closed Bug 893824 Opened 6 years ago Closed 6 years ago

3D CSS Periodic demo crashes in CreateCGPattern

Categories

(Core :: Graphics, defect, critical)

All
macOS
defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla25
Tracking Status
firefox25 + verified

People

(Reporter: BenWa, Assigned: mattwoodrow)

References

()

Details

(Keywords: crash, regression, reproducible)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-bafe6d4f-41e2-4738-8453-e94c42130715 .
 ============================================================= 

STR:
1) Open http://www.mrdoob.com/lab/javascript/threejs/css3d/periodictable/
2) Wait 5 seconds
Keywords: reproducible
The problem here was that we're trying to create a surface that is 0 sized.

CGImage creation fails (and dumps errors to stdout), and we fail DrawTarget::CreateSourceSurfaceForData.

We then fallback to Factory::CreateWrappingDataSurface which creates a SourceSurfaceRawData instead.

Then when we try draw with this surface we see that its type is TYPE_DATA, and static_cast it to DataSourceSurfaceCG.

We should probably fix that potential for an invalid cast too.
Attachment #775751 - Flags: review?(jmuizelaar)
Attachment #775751 - Flags: review?(jmuizelaar) → review+
I don't which of bug 893824, bug 900133 or bug 898129 caused it, but inbound has been closed for long enough.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e1009e4b1e1
Assignee: nobody → mh+mozilla
Assignee: mh+mozilla → matt.woodrow
Keywords: regression
https://hg.mozilla.org/mozilla-central/rev/b1b429edac78
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Reproduced nightly 2013-07-15, Mac OS X 10.7.5.
Verified fixed FF 25.0a2 (2013-09-12), 26.0a1 (2013-09-12).
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.