If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

3D CSS Periodic demo crashes in CreateCGPattern

VERIFIED FIXED in Firefox 25

Status

()

Core
Graphics
--
critical
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: BenWa, Assigned: mattwoodrow)

Tracking

({crash, regression, reproducible})

Trunk
mozilla25
All
Mac OS X
crash, regression, reproducible
Points:
---

Firefox Tracking Flags

(firefox25+ verified)

Details

(crash signature, URL)

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
This bug was filed from the Socorro interface and is 
report bp-bafe6d4f-41e2-4738-8453-e94c42130715 .
 ============================================================= 

STR:
1) Open http://www.mrdoob.com/lab/javascript/threejs/css3d/periodictable/
2) Wait 5 seconds
(Reporter)

Updated

4 years ago
Keywords: reproducible

Updated

4 years ago
(Assignee)

Comment 1

4 years ago
Created attachment 775751 [details] [diff] [review]
Don't create zero sized surfaces

The problem here was that we're trying to create a surface that is 0 sized.

CGImage creation fails (and dumps errors to stdout), and we fail DrawTarget::CreateSourceSurfaceForData.

We then fallback to Factory::CreateWrappingDataSurface which creates a SourceSurfaceRawData instead.

Then when we try draw with this surface we see that its type is TYPE_DATA, and static_cast it to DataSourceSurfaceCG.

We should probably fix that potential for an invalid cast too.
Attachment #775751 - Flags: review?(jmuizelaar)
Attachment #775751 - Flags: review?(jmuizelaar) → review+
I don't which of bug 893824, bug 900133 or bug 898129 caused it, but inbound has been closed for long enough.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e1009e4b1e1
Assignee: nobody → mh+mozilla

Updated

4 years ago
Assignee: mh+mozilla → matt.woodrow
(Reporter)

Updated

4 years ago
tracking-firefox25: --- → ?
Keywords: regression
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1b429edac78
https://hg.mozilla.org/mozilla-central/rev/b1b429edac78
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25

Updated

4 years ago
status-firefox25: --- → fixed
tracking-firefox25: ? → +
Keywords: verifyme
Reproduced nightly 2013-07-15, Mac OS X 10.7.5.
Verified fixed FF 25.0a2 (2013-09-12), 26.0a1 (2013-09-12).
Status: RESOLVED → VERIFIED
status-firefox25: fixed → verified
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.