Closed Bug 893827 Opened 11 years ago Closed 11 years ago

Disable/Stop adb when gaia is in lockscreen

Categories

(Firefox OS Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 810092

People

(Reporter: pancake, Unassigned)

Details

(Keywords: sec-moderate, sec-want, Whiteboard: [sg:dupe 810092])

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:22.0) Gecko/20100101 Firefox/22.0 (Beta/Release)
Build ID: 20130625091652

Steps to reproduce:

For security reasons it's not desirable to have full adb access to the phone when it is not unlocked. Android already have this feature together with support for certificates to authorize only 'verified' adb clients.


Actual results:

you can connect to adb shell when the phone is locked.


Expected results:

Add an option in settings to enable disable adb in lockscreen
This is not a bad feature request.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: sec-low, sec-want
Given the heavy weighting of current users toward app developers who might tend to enable adb sec-low might understate it's importance. This could be a nasty surprise for some who assume (based on Android) that a locked phone is "safe".

Paul: how do we make sure the right developers see this bug?
Group: b2g-core-security
Flags: needinfo?(ptheriault)
Keywords: sec-lowsec-moderate
I am a bit confused about this bug title - it says 'disable b2g' - I assume you mean adb, and if so this is a dupe and already implemented. See Bug 810092 and Bug 874484. 

I'll dupe this, but feel free to reopen if you mean something more subtle. The behavior at the moment that adb is disabled with the phone is locked. Furthermore, adb is also disabled after 12 hours of connection. 

For more info see this thread: https://groups.google.com/d/msg/mozilla.dev.b2g/vl2bczVZb2Y/Y_1U4x7d3pwJ
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(ptheriault)
Resolution: --- → DUPLICATE
I am testing a build from git on a gp-peak right now (as I do almost every day), and this behaviour is not happening there. I am able to connect via adb (adb shell) with the phone screen locked. Am I missing something? Or this is only working on release builds?
(In reply to pancake from comment #4)
> I am testing a build from git on a gp-peak right now (as I do almost every
> day), and this behaviour is not happening there. I am able to connect via
> adb (adb shell) with the phone screen locked. Am I missing something? Or
> this is only working on release builds?

Are you testing this on a 1.2 build? The dupe was fixed in the 1.2 timeframe.
I use BRANCH=master and Settings->DeviceInfo shows 1.2.0.0-prerelease
Whiteboard: [sg:dupe 810092]
Summary: Disable/Stop b2g when gaia is in lockscreen → Disable/Stop adb when gaia is in lockscreen
(In reply to Paul Theriault [:pauljt] from comment #3)
> I am a bit confused about this bug title - it says 'disable b2g' - I assume
> you mean adb, and if so this is a dupe and already implemented. See Bug
> 810092 and Bug 874484. 

title fixed
Group: b2g-core-security, core-security
You need to log in before you can comment on or make changes to this bug.