893853 - Assertion failure: !types->unknown(), at ../ion/MIR.h:7396

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Christian Holler (:decoder)]

The following testcase asserts on mozilla-central revision 18467a85acf6 (run with --fuzzing-safe --ion-eager):


function f() {}
new EvalTest();
function EvalTest() {
  with (this) {
    f(EvalTest)
  }
}
evaluate("var obj = new f(1, 'x');");

Comment 1

[Christian Holler (:decoder)]

Attachment: [crash-signature] Machine-readable crash signature

Comment 2

[Christian Holler (:decoder)]

JSBugMon: Bisection requested, result:
autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   http://hg.mozilla.org/mozilla-central/rev/436c88ed1e5e
user:        Hannes Verschore
date:        Tue Jun 11 16:00:54 2013 +0200
summary:     Bug 879168 - IonMonkey: Improve the typeset of |this| when inlining a constructing call, r=bhackett

This iteration took 326.199 seconds to run.

Comment 3

[Christian Holler (:decoder)]

Needinfo from Hannes based on comment 2 :)

Comment 4

[Hannes Verschore [:h4writer]]

Attachment: Patch

Comment 5

[Hannes Verschore [:h4writer]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/84e608715045

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/84e608715045

Comment 7

[Hannes Verschore [:h4writer]]

Comment on attachment 775942 [details] [diff] [review]
Patch

[Approval Request Comment]

Bug caused by (feature/regressing bug #): Bug 879168

User impact if declined: I think nothing too crazy. But there is a reason there is an assert there. Not sure if it is due to crashes or bailouts, though.

Testing completed (on m-c, etc.): m-c for the weekend

Risk to taking this patch (and alternatives if risky): I would say no risk. Very easy and understandable patch.

String or IDL/UUID changes made by this patch: /

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/48011fcf0225