Closed Bug 893858 Opened 6 years ago Closed 6 years ago

More testing for CPOWs

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: evilpie, Assigned: evilpie)

References

Details

(Whiteboard: [e10s] )

Attachments

(1 file, 1 obsolete file)

Attached patch tests and two small fixes (obsolete) — Splinter Review
I wrote some test with a CPOW that is supposed to always throw. Found some bugs on the way and fixed them.
Attachment #775705 - Flags: review?(dvander)
Attachment #775705 - Flags: review?(dvander) → review+
I want to add a few more tests here.
http://hg.mozilla.org/integration/mozilla-inbound/rev/ca8afb897e13
Whiteboard: [e10s] → [e10s] [leave open]
Oh damn. I didn't realize that this is a crash, it looked like some kind of warning on try.
Running to try as well.
Attachment #775705 - Attachment is obsolete: true
Attachment #777319 - Flags: review?(dvander)
Attachment #777319 - Flags: review?(dvander) → review+
I found an other issue, we should not return NULL from className.
Blocks: core-e10s
Assignee: general → evilpies
Status: NEW → ASSIGNED
Whiteboard: [e10s] [leave open] → [e10s]
I don't really have anything anymore to add after all.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.