Open Bug 893883 Opened 11 years ago Updated 2 years ago

dom/bindings/Makefile.in - tab prefixed comments

Categories

(Firefox Build System :: General, defect)

defect

Tracking

(Not tracked)

People

(Reporter: joey, Unassigned)

Details

Left justify or space-fill makefile comments to prevent make from attempting to evaluate them as potential target commands:



ParserResults.pkl: $(globalgen_dependencies)
<tab># Running GlobalGen.py updates ParserResults.pkl as a side-effect
	PYTHONDONTWRITEBYTECODE=1 $(PYTHON) $(topsrcdir)/config/pythonpath.py \
    $(PLY_INCLUDE) -I$(srcdir)/parser \
    $(srcdir)/GlobalGen.py $(srcdir)/Bindings.conf . \
    --cachedir=$(CACHE_DIR) \
    $(all_webidl_files)

.BindingGen: $(bindinggen_dependencies) $(binding_dependency_trackers)
<tab># Make sure .deps actually exists, since we'll try to write to it from
<tab># BindingGen.py but we're typically running in the export phase, which
<tab># is before anyone has bothered creating .deps.
	$(MKDIR) -p .deps
<tab># Pass our long lists through files to try to avoid blowing
<tab># out the command line
	echo $(all_webidl_files) > .all-webidl-file-list
	echo $? > .changed-dependency-list
<tab># BindingGen.py will examine the changed dependency list to figure out
<tab># what it really needs to regenerate.
	PYTHONDONTWRITEBYTECODE=1 $(PYTHON) $(topsrcdir)/config/pythonpath.py \
    $(PLY_INCLUDE) -I$(srcdir)/parser \
    $(srcdir)/BindingGen.py \
    $(srcdir)/Bindings.conf \
    $(CURDIR) \
    .all-webidl-file-list \
    .changed-dependency-list
	# Now touch the .BindingGen file so that we don't have to keep redoing
	# all that until something else actually changes.
	@$(TOUCH) $@
Product: Core → Firefox Build System
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.