If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add favicon to published makes pages.

RESOLVED FIXED

Status

Webmaker
Make Valet
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mjschranz, Assigned: jbuck)

Tracking

Details

Attachments

(1 attachment)

45 bytes, text/x-github-pull-request
inactivate account for kate
: review+
Details | Review | Splinter Review
(Reporter)

Description

4 years ago
Move to makes.org component when it exists.

We need some sort of favicon for the makes pages we publish. I imagine the same as webmaker.org would suffice.
(Assignee)

Updated

4 years ago
Assignee: nobody → jon
Status: NEW → ASSIGNED
Component: General → Make Valet
QA Contact: brett
(Assignee)

Comment 1

4 years ago
Created attachment 794761 [details] [review]
https://github.com/mozilla/make-valet/pull/13
Attachment #794761 - Flags: review?(kate)
Attachment #794761 - Flags: review?(kate) → review-
(Assignee)

Comment 2

4 years ago
Comment on attachment 794761 [details] [review]
https://github.com/mozilla/make-valet/pull/13

Fixed review comments
Attachment #794761 - Flags: review- → review?(kate)
Attachment #794761 - Flags: review?(kate) → review+

Comment 3

4 years ago
Commit pushed to master at https://github.com/mozilla/make-valet

https://github.com/mozilla/make-valet/commit/26b049af2b2d439ba722c7590efb1a8bae4f314c
Fix bug 893884 - Add favicon

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.